refactor/subfolder-skill-layout - #13
Merged
Merged
Conversation
npx skills copies the entire folder containing SKILL.md and only excludes .git, __pycache__ and metadata.json. With SKILL.md at the repo root, every install dragged .github/, .gitignore, scripts/, LICENSE and README.md into the consumer project. Skill content (SKILL.md, constitution.md, skills/) now lives in trustless-work-dev/, matching the frontmatter name; repo infrastructure stays at the root and is no longer installed. check-consistency.sh and CI are path-agnostic and unchanged; README links updated and all relative links verified. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Installed copies now carry the Apache-2.0 text alongside the frontmatter license declaration. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
JoelVR17
changed the title
JoelVR17
approved these changes
Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Installing the skill in a project (
npx skills add trustless-work/trustlesswork-skill) copied repo infrastructure into the consumer project:.github/,.gitignore,scripts/,LICENSEandREADME.mdall landed inside.claude/skills/trustless-work-dev/.The cause is in the skills.sh CLI: it copies the whole folder that contains
SKILL.md, and its exclusion list is hardcoded to.git,__pycache__,__pypackages__andmetadata.jsononly — there is no ignore-file or frontmatter mechanism. WithSKILL.mdat the repo root, the repo root is the skill.Fix
Move the installable content into
trustless-work-dev/(named after the skill's frontmattername):The CLI discovers skills in subdirectories when there is no root
SKILL.md, so the install command stays the same.scripts/check-consistency.shand the CI workflow usegit ls-files, so they needed no changes and still pass.trustless-work-dev/prefix and the structure tree reflects the current layout (protocol/, api/v2/, react-sdk/v2/, js-sdk/).Verified
Reproduced the dirty install from the old layout, then installed from this branch with
npx skills add <path> --copy: onlySKILL.md,constitution.mdandskills/are copied.🤖 Generated with Claude Code