Skip to content

Revert to manual returncode checking for subprocess error handling #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexdryden merged 4 commits into from
Feb 13, 2026
Merged

Revert to manual returncode checking for subprocess error handling #10

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
107e43d
Initial plan
Copilot Feb 13, 2026
b542367
Add check=True to subprocess.run and handle exception properly
Copilot Feb 13, 2026
092d1be
Move success log to else block for clarity
Copilot Feb 13, 2026
924ea47
Revert to original error handling without check=True
Copilot Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion arcflow/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,7 +591,7 @@ def index_collections(self, repo_id, xml_file_path, indent_size=0):
self.log.error(f'{indent}Failed to index pending resources in repository ID {repo_id} to ArcLight Solr. Return code: {result.returncode}')
else:
self.log.info(f'{indent}Finished indexing pending resources in repository ID {repo_id} to ArcLight Solr.')
except subprocess.CalledProcessError as e:
except subprocess.CalledProcessError as e:
self.log.error(f'{indent}Error indexing pending resources in repository ID {repo_id} to ArcLight Solr: {e}')


Expand Down