Hotfix bbcode regex

[alexdryden]

No description provided.

[alexdryden]

I think ideally we would not call this bbcode_to_html because it doesn't produce html, but that probably isn't really strictly necessary.

@graykr After applying your suggestions I was getting some double mailto:mailto. Probably the easiest way to make sure this is really doing what you expect is to look at the test cases, which I made a bit easier to read. And adding/correcting any mistakes in the test cases might be the clearest way to indicate the expected behavior.

[graykr]

(I added some comments/suggestions to the test version, but they also need to be copied to the one to be actually used in Archon.)

Also, since this is actually bbcode to xml, it looks like we'd need to encode any & in the URL to & -- this is sometimes, though not always causing issues with the EAD. Since it is causing issues sometimes, it might just be worth adding into this (poorly named) bbcode_to_html function?

[alexdryden]

It is a little hard to say without a deeper dive into Archon, but it sure seems like there are things that should be escaping for XML. I just added a function to preg_replace that uses the builtin special character escape (&<>' ' "). That will replace any of those characters that appear in any of the capture groups, which I thought should be okay because it seems like it would throw an error anywhere they showed up in this kind of content. But if you need it to just target only the url, we can do that instead (or alternatively, if you want to escape it absolutely everywhere we can just escape the entire string before doing the url substitutions). Edit: this will break nested tags, so just substituting the & during the replacements now.

I can not at all guarantee that the inline comments actually represent the target thing to find or the target thing to replace, but I tried to make it a little bit easier to read while removing the two redundant email substitutes. Double-check the examples I used in the tests to make sure I'm doing what you really want me to.

[graykr]

Thanks, Alex! I got a syntax error on the new php you added for the child class but was able to fix. Other than that, I am seeing the tests come back cleanly. Thank you so much for your work on this!

[graykr]

Suggested change

	$test_instance = new class() extends ArchonObject {
	public function __construct() {
	}
	};
	class TestArchonObject extends ArchonObject {
	public function __construct() {
	}
	};
	$test_instance = new TestArchonObject();

The earlier format is giving me a syntax error.

[graykr]

@alexdryden I did some work on this in relation to how the data is sent to the migration code. Nothing was working in ArchonRecordInspector in the migration code, even though all the tests you wrote for Archon were passing.

Eventually I realized that before archon calls bbcode_to_html it encodes the string (or, array of strings) as json, and json_encode in PHP escapes all backslashes by default. This explains why the new patterns you wrote weren't working (and the old version of the code wasn't passing any of the tests you had written, even though it should have been working for some of the basic patterns). So, as it turns out, the patterns do all seem to need those 5 repeated backslashes in them!

I will push my edits to the branch shortly.