Repository navigation
Refactor: rename tl.infer_proteoform_groups() to tl.proteoform_group_inference() - #48
Merged
Merged
Conversation
…inference() Align the function name with the noun-style naming of the other pr.tl functions (e.g. peptide_proximity, proteoform_scores). The function is unreleased, so no deprecation alias is kept. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Documentation build overview
9 files changed ·
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames
pr.tl.infer_proteoform_groups()topr.tl.proteoform_group_inference()so it follows the noun-style naming of the otherpr.tlfunctions (e.g.pr.tl.peptide_proximity(),pr.tl.proteoform_scores()). Behavior is unchanged.Related issues
None
General checklist
HISTORY.mdupdated under[Unreleased](renamed the existingAddedentry; the function was never released)♻️ Refactor / style
What was restructured and why:
Only the name changes. Updated: the definition and export (
proteopy/tl/proteoform_group_inference.py,proteopy/tl/__init__.py), the docstring references inproteopy/utils/proteoform_group_simulation.py, the Sphinx API entry (docs/sphinx/source/api/tl.rst),HISTORY.mdand the tests. One test call was wrapped to stay under 79 characters. No tutorial notebook referenced the old name.[Unreleased], so no released API is affectedNotes for reviewers
infer_proteoform_groupsalias is kept, because the function was never released.proteopy.tl.proteoform_group_inferencepoints to the function, not the module (the same pattern scanpy uses). Nothing in the repo uses the name to reach the module.🤖 Generated with Claude Code