Conversation
Contributor
Author
|
No idea what's breaking build-docs here |
Member
looks like a bug in the link checker, I'll file a bug. just ignore it for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #606
The DSA attempts to unify procedure graphs if the procedures are strongly connected. There was a bug (where the unsorted version of a collection was incorrectly used) that meant this sometimes might not happen correctly, where instead it could merge one procedure's graph with itself. This fixes that behaviour.
The DSA now merges the constraints of graphs as well when unifying.
When unifying graphs in the bottom-up phase , the DSA also now maintains the previous symbolic value analysis state and merges it with the new state from the bottom-up parameters, instead of completely overriding it.
I hope this hasn't horribly broken other things in the DSA.