Add querying container logs API with authentication#89
Open
elwincheng wants to merge 1 commit intomainfrom
Open
Add querying container logs API with authentication#89elwincheng wants to merge 1 commit intomainfrom
elwincheng wants to merge 1 commit intomainfrom
Conversation
- Implemented `getJobLogs` endpoint requiring Bearer token authentication. - Added `requireAuth` middleware to enforce authentication for protected routes. - Created comprehensive tests for job logs retrieval, including scenarios for valid and invalid authentication, missing job logs, and query parameters. - Updated `DockerMgr` to support container naming for log retrieval. - Enhanced error handling and logging for better traceability.
Collaborator
|
I can't seem to review this one myself (github :( ) but lgtm overall - is the requireauth integrated with the oauth changes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getJobLogsendpoint requiring Bearer token authentication.requireAuthmiddleware to enforce authentication for protected routes.DockerMgrto support container naming for log retrieval.