feat(apollo-vertex): add page-header component to vertex registry#465
feat(apollo-vertex): add page-header component to vertex registry#465creilly11235 wants to merge 1 commit intomainfrom
Conversation
creilly11235
requested review from
frankkluijtmans and
pieman1313
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dependency License Review
License distribution
Excluded packages
|
creilly11235
force-pushed
the
creilly11235/vertex-header-registry
branch
from
6df8faa to
0cf415e
Compare
Port page-header compound component from vertical-medical-mrs to the apollo-vertex shadcn registry. Includes back navigation, title/description, metadata fields, collapsible actions with overflow dropdown, and skeleton loading state. Update shell preview with PageHeader in InvoiceDashboard and add InvoiceDetail page with back navigation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
creilly11235
force-pushed
the
creilly11235/vertex-header-registry
branch
from
0cf415e to
984815b
Compare
pieman1313
left a comment
pieman1313
left a comment
There was a problem hiding this comment.
is this intended behaviour, or am I not using it correctly?
I made the viewport unreasonably small, and the header shrinks to the point its unreadable / unusable
| }); | ||
|
|
||
| interface PageHeaderProps | ||
| extends React.ComponentProps<"div">, |
There was a problem hiding this comment.
import from react? same for other occurrences
| }: PageHeaderCollapsibleActionsProps) { | ||
| const containerRef = React.useRef<HTMLDivElement>(null); | ||
| const rulerRef = React.useRef<HTMLDivElement>(null); | ||
| const [visibleCount, setVisibleCount] = React.useState(-1); |
There was a problem hiding this comment.
why -1? wouldn't switching to null make more sense?
There was a problem hiding this comment.
I don't think you pushed the changes yet
| "use client"; | ||
|
|
||
| /* eslint-disable max-lines -- compound component with collapsible actions + skeletons */ | ||
| import { cva, type VariantProps } from "class-variance-authority"; |
There was a problem hiding this comment.
doesn't this need to be in the dependencies?
| @@ -0,0 +1,540 @@ | |||
| "use client"; | |||
|
|
|||
| /* eslint-disable max-lines -- compound component with collapsible actions + skeletons */ | |||
There was a problem hiding this comment.
im a bit offput by the size as well, not sure what others think, but I would prefer each component in each file
On this doc page, I ended up using this work around because the preview container is artificially constraining the component and was causing some weird behavior (component was calculating page width not container width) so I had zoom to fit. If you have ideas for a better work around I'd be happy to try it! |
pieman1313
left a comment
pieman1313
left a comment
There was a problem hiding this comment.
the old changes still show up, did you push the latest ones?
shouldn't we then switch to container queries instead of page widths? it would make this more reusable, since this will break as well if used in conjunction with the shell, right? |
2 participants
Summary
page-headercompound component from vertical-medical-mrs to the apollo-vertex shadcn registryScaledPreviewwrapper to simulate full-width layout in narrow docs containers🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com