feat(flow-skill): robust JMESPath impl instructions

[rockymadden]

No description provided.

[github-actions]

Claude finished @rockymadden's task in 1m 49s —— View job

---

Summary

This PR replaces the incorrect legacy ((fields.<fieldName><\value`>))` JMESPath filter syntax with a comprehensive, correct JMESPath reference section. It adds ~67 lines of new documentation covering syntax rules, supported operators/functions, combining conditions, worked examples, a step-by-step build guide, and an anti-patterns table — all within the connector-trigger implementation reference.

Change-by-Change Review

1. skills/uipath-maestro-flow/references/plugins/connector-trigger/impl.md — OK

What changed:

• Line 127: Inline example updated from the broken ((fields.<fieldName><\value`>))to a valid(contains(subject, 'urgent'))` example.
• Line 139: filterExpression table description now links to the new ## JMESPath Filter Expressions section instead of inlining incorrect syntax.
• Lines 147–211: New ## JMESPath Filter Expressions section with:
  • 6 numbered syntax rules (clear, prescriptive, copy-paste ready)
  • Supported functions/operators table with examples
  • Combining conditions table (&&, ||, ())
  • 7 worked examples covering real scenarios
  • Step-by-step guide for building filter expressions from filterFields
  • "What NOT to Generate" anti-patterns table — 5 invalid patterns with explanations and corrections
• Line 308: Troubleshooting table updated with correct syntax and cross-link.
• Line 321: New debug tip feat(CodedAgents): llm and interruption patterns #8 — warns about validating field names against filterFields to avoid silent no-match.

Assessment: This is a well-structured, high-quality documentation addition. The content is prescriptive, internally consistent, and follows the repo's conventions for LLM-consumable instructions.

Minor observations (Low):

• Line 207, 210 (impl.md:207,210): The backtick-heavy cells in the "What NOT to Generate" table ( fields.fromAddress == value and `((fields.subject<\`test\`>))`) render correctly in GitHub-flavored markdown but may look confusing in some markdown parsers due to nested backtick escaping. This is cosmetic and not a blocker.

What's Missing

Nothing identified. The change is well-scoped to the JMESPath filter documentation gap. The existing CODEOWNERS, test tasks, and skill structure are all unaffected and already in good shape.

Area Ratings

Area	Status	Notes
Frontmatter	OK	Not modified — existing frontmatter valid
E2E Tests	OK	Documentation-only change; existing tests cover the skill
Skill Body	OK	Not modified
References & Assets	OK	New section is well-structured, all internal links resolve
Repo Hygiene	OK	No secrets, no cross-skill refs, CODEOWNERS already covers this path

Issues for Manual Review

• JMESPath accuracy: Verify that the documented syntax (single parens, bare field names, single-quoted strings, contains/starts_with functions) matches the actual UiPath Integration Service filter engine behavior. The PR corrects what appears to be known-wrong legacy syntax, but the reviewer should confirm against the IS API or runtime.

Conclusion

Clean PR — no issues found above Low severity. The change replaces demonstrably incorrect filter syntax with comprehensive, LLM-friendly JMESPath documentation. The anti-patterns table is a particularly strong addition that should prevent common agent mistakes. Approve.

---

• Read review criteria and project conventions
• Run diff and read existing PR conversation
• Read full changed file for context
• Perform review checks (links, cross-refs, secrets, etc.)
• Post review findings
  |

[tmatup]

why 'urgent' here?