Allow hash characters in file names passed to NetcdfFiles#1494
Merged
Conversation
When opening a file through NetcdfFiles, any potential URI fragments are removed for certain checks. This only needs to be done for non-local files, so we skip this for local files. Fixes Unidata#1492
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
When opening a file through NetcdfFiles, any potential URI fragments are removed for certain checks. This only needs to be done for non-local files, so we skip this for local files. Fixes #1492
Additionally, fix test that uses the nexrad level2 AWS S3 bucket (update bucket name).
PR Checklist
until ready for review