Fix: Command Line Argument Handling #1036
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for command line arguments handling
Problem
When running on Awake and passing arguments via the command line, these values are not applied, the default settings are used instead.
Root Cause
The logic inside the
SignalingManager’sAwake()function creates a signaling object that is passed to the_Run()function.Because the
signalingparameter in_Run()is notnull, it prevents the function from creating a new signaling instance after the command-line arguments have been evaluated.Solution
The creation of the signaling and conf objects has been removed from
Awake(), and both are now set tonull.By doing this, the signaling object is created inside
_Run()using the updated settings that include the values from the command-line arguments.