Release 4.3.0 rc5#1726
Conversation
Co-authored-by: Demian Katz <demian.katz@villanova.edu>
Co-authored-by: Demian Katz <demian.katz@villanova.edu>
Bumps [node-forge](https://github.com/digitalbazaar/forge) from 1.3.3 to 1.4.0. - [Changelog](https://github.com/digitalbazaar/forge/blob/main/CHANGELOG.md) - [Commits](digitalbazaar/forge@v1.3.3...v1.4.0) --- updated-dependencies: - dependency-name: node-forge dependency-version: 1.4.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps and [brace-expansion](https://github.com/juliangruber/brace-expansion). These dependencies needed to be updated together. Updates `brace-expansion` from 1.1.12 to 1.1.13 - [Release notes](https://github.com/juliangruber/brace-expansion/releases) - [Commits](juliangruber/brace-expansion@v1.1.12...v1.1.13) Updates `brace-expansion` from 2.0.2 to 2.0.3 - [Release notes](https://github.com/juliangruber/brace-expansion/releases) - [Commits](juliangruber/brace-expansion@v1.1.12...v1.1.13) --- updated-dependencies: - dependency-name: brace-expansion dependency-version: 1.1.13 dependency-type: indirect - dependency-name: brace-expansion dependency-version: 2.0.3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…gin (UniversalViewer#1719) Removes [serialize-javascript](https://github.com/yahoo/serialize-javascript). It's no longer used after updating ancestor dependencies [serialize-javascript](https://github.com/yahoo/serialize-javascript), [terser-webpack-plugin](https://github.com/webpack/terser-webpack-plugin) and [copy-webpack-plugin](https://github.com/webpack/copy-webpack-plugin). These dependencies need to be updated together. Removes `serialize-javascript` Updates `terser-webpack-plugin` from 5.3.16 to 5.4.0 - [Release notes](https://github.com/webpack/terser-webpack-plugin/releases) - [Changelog](https://github.com/webpack/terser-webpack-plugin/blob/main/CHANGELOG.md) - [Commits](webpack/terser-webpack-plugin@v5.3.16...v5.4.0) Updates `copy-webpack-plugin` from 13.0.1 to 14.0.0 - [Release notes](https://github.com/webpack/copy-webpack-plugin/releases) - [Changelog](https://github.com/webpack/copy-webpack-plugin/blob/main/CHANGELOG.md) - [Commits](webpack/copy-webpack-plugin@v13.0.1...v14.0.0) --- updated-dependencies: - dependency-name: serialize-javascript dependency-version: dependency-type: indirect - dependency-name: terser-webpack-plugin dependency-version: 5.4.0 dependency-type: indirect - dependency-name: copy-webpack-plugin dependency-version: 14.0.0 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
New description for manifestExclude
…config-docs-cleanup Normalize markdown style in CONFIG.md.
…fix-next-prev-outline Fix extra outlines in next/prev buttons.
…-width Add minimum image width to download options
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@demiankatz is attempting to deploy a commit to the Universal Viewer Team on Vercel. A member of the Team first needs to authorize it. |
This reverts commit 97b7f4e.
|
I'm seeing that the pop-up search display options are partly hidden behind the image when running a search. See attached image UV v3 image |
|
Thanks for reporting that, @LanieOkorodudu -- I'm sure that's not intentional; looks like a z-order issue in the CSS somewhere. Do you see the same behavior in UV 4.2.1? If it's a newly-introduced bug in 4.3, we should definitely fix it before making a release since we don't want to introduce a new known bug. If it's an existing problem, I'd still be open to fixing it immediately, but if we don't want to delay 4.3.0 further, I think we could also justify releasing as-is and fixing in 4.3.1 in the interest of keeping things moving along. I won't have time to look into this before next week, but maybe @jamesmisson or @LlGC-jop might have an idea if there's an urgent need for a solution. (I also don't mean to omit @Saira-A from the list -- but I think James and Jonathan have been in the CSS most recently :-) ). |
|
This is how it looks in 4.2.1, so still not right but in a different way: I also don't have time until next week but the top results are completely unclickable so I think we should aim to get it fixed before the release @demiankatz |
|
Now that @Saira-A has fixed the problem that @LanieOkorodudu reported, we'll need to make an RC6 release. Could somebody give me an approval here so I can merge this and get started on the next one? (No rush -- I'm also still waiting for confirmation from the BL team that everyone is ready to move forward). |
demiankatz
dismissed
Saira-A’s stale review
The merge-base changed after approval.
demiankatz
dismissed
Saira-A’s stale review
The merge-base changed after approval.
demiankatz
merged commit ee2c269
into
UniversalViewer:release-4.3.0
|
Not sure what happened here -- Saira's review got dismissed after she left it, but the message doesn't seem to match the reality of what happened. It's particularly puzzling that the dismissal was done in my name -- that wasn't me! In any case, I'm just bypassing rules to get this merged since as far as I can tell, it really does have a legitimate approval. |
5 participants
This is the fifth release candidate for 4.3.0, fixing more bugs discovered since RC4 (#1715), rebuilding the autogenerated docs, and updating further dependencies.
This RC also includes some further adjustments to the release workflow in an effort to get NPM publishing working again.