Skip to content

feat(components) Create CompTeam component#72

Open
Youdaox wants to merge 2 commits into
mainfrom
feat/60-comp-team-section
Open

feat(components) Create CompTeam component#72
Youdaox wants to merge 2 commits into
mainfrom
feat/60-comp-team-section

Conversation

@Youdaox

@Youdaox Youdaox commented May 18, 2026

Copy link
Copy Markdown
Contributor

Description

created the CompTeam.tsx component for about page.

Closes #60

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Manual testing (requires screenshots or videos)

layout:
manually tested through rendering on homepage
image

padding:
image

  • not mobile responsive, font unknown

Checklist before requesting a review

  • My code follows the style guidelines of this project
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation if needed
  • I've requested a review from another team member

@Youdaox Youdaox changed the title Created CompTeam component feat(Component) Create CompTeam component May 18, 2026
@Youdaox Youdaox changed the title feat(Component) Create CompTeam component feat(components) Create CompTeam component May 18, 2026

@aleckshen aleckshen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small minor change also I think you accidentally committed a duplicate file outside of the CompTeam folder, can you remove that too. Good to merge after!

<h1 className="font-bold text-4xl text-brand-navy">{teamName}</h1>

{photo && (
<div className="relative aspect-video w-5xl">

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

w-5xl is not a valid tailwind utility

@aleckshen aleckshen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FRONTEND] Create Comp team section on About page

2 participants