[k2] implemented aes-128-gcm, aes-256-gcm + supported "no padding" in f$openssl_encrypt and f$openssl_decrypt builtins#1517
Open
T-y-c-o-o-n wants to merge 9 commits intomasterfrom
Open
Conversation
T-y-c-o-o-n
changed the title
apolyakov
reviewed
Feb 4, 2026
apolyakov
approved these changes
Feb 8, 2026
apolyakov
requested changes
Feb 9, 2026
Contributor
apolyakov
left a comment
apolyakov
left a comment
There was a problem hiding this comment.
We've decided to make these changes backward compatible, so this PR needs some changes
T-y-c-o-o-n
changed the title
T-y-c-o-o-n
changed the title
T-y-c-o-o-n
force-pushed
the
n.siniachenko/fix-unpad-error
branch
from
71356ef to
9c32191
Compare
apolyakov
reviewed
Feb 17, 2026
Contributor
apolyakov
left a comment
apolyakov
left a comment
There was a problem hiding this comment.
Comment 1: Typo (line 301, 379)
"doesn not" → "does not"
Comment 2: Misleading variable names (lines 316, 391)
cbc_encrypt/cbc_decrypt → encrypt/decrypt (now handles both CBC and GCM)
Comment 3: Simplify AEAD validation (lines 292-302, 346-352)
Validation is scattered across the function. Consider consolidating into one block. Also, line 348's warning says "when using AEAD mode" but is reached when NOT in AEAD mode.
Comment 4: Add comment (line 234-238)
Consider adding a comment that IV length validation is handled by the crypto component (differs from legacy runtime).
Comment 5: Missing GCM in cipher methods (lines 268-272)
Add AES_128_GCM and AES_256_GCM to the return value.
added 8 commits
February 17, 2026 19:04
T-y-c-o-o-n
force-pushed
the
n.siniachenko/fix-unpad-error
branch
from
bbfeb0f to
7fa4957
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.