Skip to content

[k2] replace tl::is_int32_overflow with std::in_range#1527

Merged
apolyakov merged 1 commit intomasterfrom
apolyakov/k2-get-rid-of-tl-int32-overflow
Feb 16, 2026
Merged

[k2] replace tl::is_int32_overflow with std::in_range#1527
apolyakov merged 1 commit intomasterfrom
apolyakov/k2-get-rid-of-tl-int32-overflow

Conversation

@apolyakov
Copy link
Contributor

@apolyakov apolyakov commented Feb 16, 2026

No description provided.

@apolyakov apolyakov added this to the next milestone Feb 16, 2026
@apolyakov apolyakov self-assigned this Feb 16, 2026
@apolyakov apolyakov added the k2 k2 related label Feb 16, 2026
PetrShumilov
PetrShumilov approved these changes Feb 16, 2026
View reviewed changes
Copy link
Contributor

@PetrShumilov PetrShumilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@apolyakov apolyakov merged commit 01a7aa6 into master Feb 16, 2026
10 of 13 checks passed
@apolyakov apolyakov deleted the apolyakov/k2-get-rid-of-tl-int32-overflow branch February 16, 2026 17:22
apolyakov added a commit that referenced this pull request Feb 18, 2026
@apolyakov
[k2] revert "[k2] replace tl::is_int32_overflow with std::in_range (#…
64b5dc6 
…1527)"

It turns out it's intentional that the code didn't use standard
algorithms here. The reason for that is that it doesn't matter for
TL whether tl::int is signed or unsigned

This reverts commit 01a7aa6.
apolyakov added a commit that referenced this pull request Feb 18, 2026
@apolyakov
[k2] revert "[k2] replace tl::is_int32_overflow with std::in_range (#…
5aa00a1 
…1527)" (#1530)

It turns out it's intentional that the code didn't use standard
algorithms here. The reason for that is that it doesn't matter for
TL whether tl::int is signed or unsigned

This reverts commit 01a7aa6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PetrShumilov PetrShumilov PetrShumilov approved these changes

@astrophysik astrophysik Awaiting requested review from astrophysik

Assignees

@apolyakov apolyakov

Labels

k2 k2 related

Projects

None yet

Milestone

next

Development

Successfully merging this pull request may close these issues.

2 participants

@apolyakov @PetrShumilov

Comments