Skip to content

State machine experiment #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidsteiner wants to merge 14 commits into
base: main
Choose a base branch
from
Open

State machine experiment #317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
1c0233c
Refactor each session state into its own module
davidsteiner Mar 16, 2026
ec931c1
Move further logic into state variants
davidsteiner Mar 17, 2026
92b16e5
Proof-of-concept to move heartbeat handler into session state
davidsteiner Mar 17, 2026
e46905c
Move is_awaiting_logon and is_awaiting_logout logic to session state
davidsteiner Mar 17, 2026
7fcbb24
Move on_disconnect handling to state variants
davidsteiner Mar 17, 2026
47d1a94
Move verification methods from session to session state
davidsteiner Mar 17, 2026
79518ab
Move process_message and a bunch more functions off of session
davidsteiner Mar 17, 2026
c8b0e37
Move bulk of message sending logic out of session
davidsteiner Mar 17, 2026
a3ef9e5
Break session context out into its own module
davidsteiner Mar 17, 2026
3fc4d4b
Final touches to make session thin
davidsteiner Mar 17, 2026
8916920
Move context out of state submodule
davidsteiner Mar 17, 2026
7ee0e87
Remove make_ctx as its use is confusing
davidsteiner Mar 17, 2026
e1671fe
Try to clean up some boilerplate in incoming message handling
davidsteiner Mar 17, 2026
a843ec9
Break out free functions for message sending
davidsteiner Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions crates/hotfix/src/initiator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,8 +387,6 @@ mod tests {

#[tokio::test]
async fn test_send_delegates_to_session_handle() {
use crate::session::error::SendOutcome;

let listener = TcpListener::bind("127.0.0.1:0").await.unwrap();
let port = listener.local_addr().unwrap().port();
let config = create_test_config("127.0.0.1", port);
Expand All @@ -402,9 +400,13 @@ mod tests {
.await
.expect("initiator should connect");

// Message should be received by session and persisted (seq 2 after Logon)
// Session is in AwaitingLogon (no logon response from counterparty),
// so send should be rejected — only Active sessions accept app messages
let result = initiator.send(DummyMessage).await;
assert!(matches!(result, Ok(SendOutcome::Sent { .. })));
assert!(
matches!(result, Err(crate::session::error::SendError::Disconnected)),
"expected Disconnected error, got: {result:?}"
);
}

#[tokio::test]
Expand Down
Loading
Loading