chore: relocate servers exception definition to exception.py for clarity#210
Open
LVivona wants to merge 7 commits intoVectorInstitute:mainfrom
Open
chore: relocate servers exception definition to exception.py for clarity#210LVivona wants to merge 7 commits intoVectorInstitute:mainfrom
LVivona wants to merge 7 commits intoVectorInstitute:mainfrom
Conversation
This change separates the custom exception definition from the config_parser module. It improves code organization and aligns with single-responsibility principles.
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #210 +/- ##
=======================================
Coverage 93.13% 93.13%
=======================================
Files 32 33 +1
Lines 3596 3597 +1
Branches 184 263 +79
=======================================
+ Hits 3349 3350 +1
Misses 247 247 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lotif
requested changes
Jul 22, 2025
lotif
approved these changes
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change separates the custom exception definition from the
config_parsermodule. It improves code organization and aligns with single-responsibility principles by moving exception-related logic to its ownexception.pyfile, making both modules easier to maintain and extend.PR Type
[x]Refactor[ ]Feature[ ]Fix[ ]Documentation[ ]OtherShort Description
Refactored code by relocating exception handling from
config_parser.pyto a new moduleexception.py.ClickUp Ticket(s)
N/A
Tests Added