Repository navigation
Say when the release actually stops for approval - #40
Merged
Merged
Conversation
RELEASING.md said the workflow waits for approval before pushing. It waits before starting: the job runs inside the nuget environment, so GitHub holds it at step zero. Approving means "start this release", not "these packages look right" — nothing is built, tested or packed until it happens, and once it does the job runs to the end without stopping again. That is still worth having, because a tag pushed by accident publishes nothing on its own. But it is not the review the document described, and the difference decides whether the gate is any use: seeing the packages before deciding needs the job split in two, with only the pushing half in the environment. That is written down now rather than left to be discovered. NUGET_USER is named rather than described, because describing it was not enough. It is the nuget.org account that created the policy, which is not always the one that owns the packages, and nuget.org says exactly that in the error when it is wrong. The 401 it fails with is now in the recovery list, along with the part that matters: the tag does not need to move, re-running the failed job is enough.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RELEASING.md said the workflow waits for approval before pushing. It waits before starting: the job runs inside the nuget environment, so GitHub holds it at step zero. Approving means "start this release", not "these packages look right" — nothing is built, tested or packed until it happens, and once it does the job runs to the end without stopping again.
That is still worth having, because a tag pushed by accident publishes nothing on its own. But it is not the review the document described, and the difference decides whether the gate is any use: seeing the packages before deciding needs the job split in two, with only the pushing half in the environment. That is written down now rather than left to be discovered.
NUGET_USER is named rather than described, because describing it was not enough. It is the nuget.org account that created the policy, which is not always the one that owns the packages, and nuget.org says exactly that in the error when it is wrong. The 401 it fails with is now in the recovery list, along with the part that matters: the tag does not need to move, re-running the failed job is enough.