Repository navigation
Take the named-member overloads a migration writes - #43
Merged
Merged
Conversation
ForMember by name, MapFrom by name, ForAllMembers, and ForSourceMember with DoNotValidate. They exist because the library this one is a drop-in for has them and a configuration that chooses a member somewhere a lambda cannot reach had to be rewritten by hand. All four were run side by side against AutoMapper and answer the same. A dotted name walks a path, the shape the expression overloads already took, and it is resolved while the configuration is built rather than when a map runs: a misspelling is a configuration error instead of a member that quietly maps to nothing. The expression overloads stay the ones to prefer, since they keep the compiler involved, and the documentation says so. The analyser learned the string form as well, so a member named as text is still tracked by the checks that say two calls disagree about it. The rest of the surface comparison is deliberately not here. Copying the overload list wholesale would break source compatibility: over there the extra PreCondition overloads make o.PreCondition(s => false) ambiguous, and that call compiles here today.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ForMember by name, MapFrom by name, ForAllMembers, and ForSourceMember with DoNotValidate. They exist because the library this one is a drop-in for has them and a configuration that chooses a member somewhere a lambda cannot reach had to be rewritten by hand. All four were run side by side against AutoMapper and answer the same.
A dotted name walks a path, the shape the expression overloads already took, and it is resolved while the configuration is built rather than when a map runs: a misspelling is a configuration error instead of a member that quietly maps to nothing. The expression overloads stay the ones to prefer, since they keep the compiler involved, and the documentation says so.
The analyser learned the string form as well, so a member named as text is still tracked by the checks that say two calls disagree about it.
The rest of the surface comparison is deliberately not here. Copying the overload list wholesale would break source compatibility: over there the extra PreCondition overloads make o.PreCondition(s => false) ambiguous, and that call compiles here today.