Repository navigation
Let the icon show a shape turning into another one - #47
Merged
Merged
Conversation
The old mark was a filled rounded square and an outlined one, overlapping. It said there are two things here, a source and a destination, but nothing about what happens between them — and it was the same two shapes in the same two colours, so the eye had no reason to read one as becoming the other. Now a square goes in, an arrow crosses, and a circle comes out. The shape itself changes, which is the whole of what the library does: one type in, another type out. It also stops competing with Mediarion's mark, which is a centre with three satellites; the two still share the navy tile and the same mint and amber, so they read as a pair without reading as the same drawing. The icon gains a source. There was only icon.png before, drawn once and not reproducible, so changing it meant redrawing it by hand. Now icon.svg holds the geometry and tools/draw-icon.py draws the PNG from the same numbers at eight times the size, reducing with LANCZOS. That is not an SVG renderer and it is not trying to be — the numbers are written twice, and the script says so, so the two files have to be changed together. Verified by packing Mapperion and comparing the icon.png inside the nupkg against the file in the tree. NuGet keeps whatever icon a version was published with, so 0.14.0 and earlier go on showing the old mark and this one appears from the next release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old mark was a filled rounded square and an outlined one, overlapping. It said there are two things here, a source and a destination, but nothing about what happens between them — and it was the same two shapes in the same two colours, so the eye had no reason to read one as becoming the other.
Now a square goes in, an arrow crosses, and a circle comes out. The shape itself changes, which is the whole of what the library does: one type in, another type out. It also stops competing with Mediarion's mark, which is a centre with three satellites; the two still share the navy tile and the same mint and amber, so they read as a pair without reading as the same drawing.
The icon gains a source
There was only
icon.pngbefore, drawn once and not reproducible, so changing it meant redrawing it by hand. Nowicon.svgholds the geometry andtools/draw-icon.pydraws the PNG from the same numbers at eight times the size, reducing with LANCZOS. That is not an SVG renderer and it is not trying to be — the numbers are written twice, and the script says so, so the two files have to be changed together.Two things in the drawing are easy to get wrong and are written down in the script:
Checks
Packed
Mapperionand compared theicon.pnginside the.nupkgagainst the file in the tree — same 6575 bytes, same SHA-256. Same dimensions and mode as before, 128×128 RGBA, so nothing downstream has to care.One file feeds all six packages through
PackageIconinDirectory.Build.props, and it is also the site's logo and favicon through_appLogoPathand_appFaviconPath, so regenerating it updates all three places.NuGet keeps whatever icon a version was published with, so 0.14.0 and earlier go on showing the old mark and this one appears from the next release onwards.