Repository navigation
fix: stop blaming PATH when the Very Good CLI version cannot be read - #176
Merged
Merged
Conversation
ryzizub
marked this pull request as ready for review
October 13, 2026 09:31
Contributor
|
Heads up — I'm auto-updating this PR by merging the latest |
Contributor
|
I tried to auto-update this PR with |
ryzizub
force-pushed
the
fix/hook-blames-path-for-stale-snapshot
branch
from
October 13, 2026 20:59
35b51d0 to
78c0e51
Compare
Contributor
|
Heads up — I'm auto-updating this PR by merging the latest |
1 similar comment
Contributor
|
Heads up — I'm auto-updating this PR by merging the latest |
Contributor
|
I tried to auto-update this PR with |
ryzizub
force-pushed
the
fix/hook-blames-path-for-stale-snapshot
branch
2 times, most recently
from
October 20, 2026 12:45
d32b0e2 to
672ab7d
Compare
ryzizub
changed the title
ryzizub
force-pushed
the
fix/hook-blames-path-for-stale-snapshot
branch
from
October 20, 2026 13:08
672ab7d to
9e07451
Compare
Closes #171 Two bugs made the SessionStart hook blame PATH for a Dart SDK upgrade. `very_good --version` was read with `head -1`. When the shim's snapshot is stale it falls back to `dart pub global run`, which prints its resolution chatter to stdout ahead of the version, so the first line held no version and a working CLI read as unverifiable. Match past the first line, anchored so a version-shaped fragment of a path in that chatter cannot win: a stub whose chatter names /tmp/vgv-1.2.3/pkg reads as `outdated:1.2.3` unanchored. `unverifiable` then covered both an absent dart and an unreadable version, and all three hooks reported it as a PATH problem. Split it on `command -v dart`: `dart_missing` keeps the PATH advice, no longer naming one shell's startup file, and `unverifiable` points at the rebuild and the `/mcp` reconnect a server started before the upgrade needs. The stubs printed "very_good 1.5.0"; the real CLI prints a bare "1.5.0", so they now print that. jq reaches the hooks through a symlinked directory, because its own directory holds dart on a Homebrew machine and the dart_missing cases then ran the wrong branch; each suite refuses to run if dart resolves on its base PATH.
ryzizub
force-pushed
the
fix/hook-blames-path-for-stale-snapshot
branch
from
October 20, 2026 13:11
9e07451 to
7f27e7f
Compare
erickzanardo
approved these changes
Oct 20, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #171
Two bugs made the SessionStart hook blame
PATHfor a Dart SDK upgrade.very_good --versionwas read withhead -1. When the shim's snapshot is stale it falls back todart pub global run, which prints its resolution chatter to stdout ahead of the version, so a working CLI read as unverifiable. The match now looks past the first line, anchored so a version-shaped fragment of a path in that chatter cannot win instead.unverifiablethen covered both an absentdartand an unreadable version, and all three hooks reported it as aPATHproblem. It now splits oncommand -v dart:dart_missingkeeps the PATH advice without naming one shell's startup file, andunverifiablepoints at the rebuild and the/mcpreconnect a server started before the upgrade needs.Type of Change
feat)fix)refactor)docs)ci)chore)🤖 Generated with Claude Code