TypeStore: round record size up to alignment for MSVC#1068
Merged
Conversation
Vexu
reviewed
Jul 4, 2026
| int x; | ||
| } AlignedStruct; | ||
|
|
||
| _Static_assert(_Alignof(AlignedStruct) == 16, ""); |
Owner
There was a problem hiding this comment.
Could you add a test case that only works with this change applied?
Collaborator
Author
There was a problem hiding this comment.
Nice catch, I was testing a bunch of combos and used the wrong one - I rebased and switched it so the __declspec is before the typedef
ehaas
force-pushed
the
msvc-aligned-struct-size
branch
from
9fd79e9 to
05e2224
Compare
https://godbolt.org/z/YehvKEqxv https://learn.microsoft.com/en-us/cpp/cpp/align-cpp?view=msvc-170 `__declspec(align(#)) can only increase alignment restrictions.`
Collaborator
Author
|
Pushed a few more fixes - prevent underaligned enums in msvc and a fix for record alignment through multiple layers of typedefs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This regresses 3 record tests but brings the overall number of failing ones down to 61. I included the msvc-enum branch just to avoid conflicts, #1067 should be merged first.