Compilation: define __BLOCKS__ when blocks are enabled#1074
Open
vancluever wants to merge 1 commit into
Open
Conversation
Owner
|
This is included in #971 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gets defined when blocks are enabled in clang: https://github.com/llvm/llvm-project/blob/9e22a5950e51ace7f50729d7f556ca99d06fa8bb/clang/lib/Frontend/InitPreprocessor.cpp#L1010
Found while trying to translate
#include <CoreVideo/CoreVideo.h>on MacOS.PS: Not too sure if this should be implicit or not somewhere, but
-fblocksspecifically needs to be enabled when doing C translation for the MacOS frameworks that employ blocks. I don't recall if this is necessary or not in Zig right now currently (it might just be in our flags somewhere that I haven't seen yet).