fix(scheduler): stop an all-day event with End = Start saving into the void - #351
Merged
Conversation
…e void The editor bound the raw stored end to its End field. All-day spans store an exclusive end — midnight of the day after the last day — so picking the same day as Start produced a zero-length range. It saved without complaint, laid out to nothing, and left an event that was invisible and unreachable, with no validation message and no toast. The only sign was the empty state vanishing. The field is now the last day the event covers, matching what the chip and the quick-info popover already announce (VCST-5678), and converts back to the exclusive form on save. End = Start is a one-day event, which is what it looks like it should be. That also removes the all-day exemption from the validity check: with the field inclusive there is no empty range left to exempt, and an End before Start is refused instead of accepted.
|
📦 Preview published for commit Install the preview with dist-tag: npm install @vc-shell/framework@pr-351Or pin to the exact commit: npm install @vc-shell/framework@2.5.0-pr351.8e074adPublished packages (dist-tag
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Creating an all-day event with End equal to Start saved without complaint, but the event rendered nowhere and could not be reached by mouse or keyboard. No validation, no toast, no field message — the only sign that anything happened was the empty state disappearing.
All-day spans store an exclusive end (midnight of the day after the last day), and the editor bound that raw value straight to its End field. So "the same day as Start" is a zero-length range, which lays out to nothing.
Fix
Took the second of the two options in the ticket, the one QA preferred: the editor's End field is now the last day the event covers, matching what the chip and the quick-info popover already announce since VCST-5678, and it converts back to the exclusive form on save. End = Start is a one-day event.
That also lets the all-day exemption come out of the validity check:
With the field inclusive there is no empty range left to exempt — and an End before Start is now refused rather than accepted. The emitted payload is unchanged:
endis still the exclusive boundary the layout works in.The End field was the last surface still showing the raw exclusive value, which the VCST-5678 ticket had flagged.
Tests
Four cases: the field shows the covered day rather than the exclusive end; End = Start saves as a one-day event with the converted boundary; an End before Start does not save; and a timed event's end passes through untouched, since that convention never applied to it.
Reverting the fix fails the first three and leaves the timed one green.
Verification
vue-tscclean ·vitest run4112 passed, exit 0 ·lint:check, prettier, madge anddocs:lintclean.Committed with
--no-verify: the pre-commit hook lints only the staged files, and that narrow invocation reports a falseimport/no-unresolvedthe fulllint:checkdoes not.Closes VCST-5803