Simplify output of docs pages for navigation#116
Open
Hans5958 wants to merge 5 commits intoVocaDB:mainfrom
Open
Simplify output of docs pages for navigation#116Hans5958 wants to merge 5 commits intoVocaDB:mainfrom
Hans5958 wants to merge 5 commits intoVocaDB:mainfrom
Conversation
Hans5958
force-pushed
the
layout/simplify-out
branch
2 times, most recently
from
99e5215 to
7dee84a
Compare
The output of this function has unused data (such as the page body/content) that is included in all pages. Simplifying the output to only included used properties would result in smaller page size.
A little bit of renaming from blog terms into docs terms. Also merge function that is used only once.
Hans5958
force-pushed
the
layout/simplify-out
branch
from
b0caac0 to
1ee3fe2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
pagesvariable used in navigation (was thegetDocsPaths()function, now just merged into one file after refactor) has unused data (such as the page body/content) that is included in all pages with navigation.Simplifying the variable to only included used properties would result in smaller page size. As a proof, the build size went from 639 MB to 84.0 MB (86.9% decrease).
Also, I did some refactoring, mainly to convert blog terms into documentation terms.