Add university events color picker to settings#95
Merged
Conversation
- Add API methods for calendar preferences (getCalendarPreferences, setUniCalCategoryPreference, setAllUniCalCategoriesColor) - Add color picker UI in Settings for university calendar events - Convert between Google Calendar color IDs (1-11) and hex values
miretskydatwit
requested review from
miretskydatwit
and removed request for
DMFriends
Member
|
@jaspermayone the state of the color dropdown is not saved when I exit out of the extension |
Contributor
|
you can convert this to a proper PR when it's fixed/resolved |
Cattn
requested changes
Jan 29, 2026
Contributor
Cattn
left a comment
Cattn
left a comment
There was a problem hiding this comment.
@jaspermayone please look into this
Member
Author
|
@Cattn i think its good for review? |
jaspermayone
requested review from
Cattn
and removed request for
miretskydatwit
Contributor
this needs to be resolved |
The university events color picker was not properly saving the selected color because the async API call was not awaited. This caused the extension popup to close before the preferences were saved to the backend. Changes: - Converted getter/setter pattern to async function handler - Added proper await for API.setAllUniCalCategoriesColor() - Added success/error snackbar notifications - Added error handling and logging Fixes the issue where color selection was lost on extension restart.
Member
Author
|
@Cattn this is good for re-review |
Member
|
I want to test this before we merge |
… if user sets another color
…f sync uni cal events is on
Cattn
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #233 (frontend companion to backend PR #249)
Test plan