feat!: Split BinaryenCallRef and BinaryenReturnCallRef in c api
#8121
+35
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
reviewed
Dec 16, 2025
kripken
reviewed
Dec 16, 2025
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
Please mention this in the CHANGELOG.md (we try to do that for all breaking changes)
Contributor
Author
|
Made those changes. |
kripken
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr splits
BinaryenReturnCallReffromBinaryenCallRefin the c api, to be more inline with both the js api and the api's forCallandCallIndirect.Breaking: This is breaking as the api for
CallRefno longer includes theisReturnparamCloses: #8110