Skip to content

Replaced deprecated InvalidAccessError with NotAllowedError#278

Merged
mjwilson-google merged 1 commit intoWebAudio:gh-pagesfrom
nikelborm:deprecated-invalid-access-error
Dec 9, 2025
Merged

Replaced deprecated InvalidAccessError with NotAllowedError#278
mjwilson-google merged 1 commit intoWebAudio:gh-pagesfrom
nikelborm:deprecated-invalid-access-error

Conversation

@nikelborm
Copy link
Contributor

@nikelborm nikelborm commented Dec 9, 2025 •
edited
Loading

According to Web IDL spec on InvalidAccessError:

Deprecated. Use TypeError for invalid arguments, "NotSupportedError" DOMException for unsupported operations, and "NotAllowedError" DOMException for denied requests instead.

Previously, while trying to open MIDIPort, "InvalidAccessError" DOMException was thrown when...

the device is unavailable (e.g., is already in use by another process and cannot be opened, or is disconnected)

In this case, I believe NotAllowedError fits well, according to its Web IDL spec description:

The request is not allowed by the user agent or the platform in the current context, possibly because the user denied permission.

Security and permissions reasons are only a subset of the appropriate causes, according to this definition. An attempt to open the port can fail. Somebody's exclusive lock on the port, or the port being disconnected, is the current context driving the platform's decision not to allow the operation.

And in the context of forbidden .send calls:

If data is a System Exclusive message, and the MIDIAccess did not enable System Exclusive access, throw an InvalidAccessError exception.

NotAllowedError fits even better, because it fits an explicitly defined subset of permission errors.

@nikelborm
Copy link
Contributor Author

nikelborm commented Dec 9, 2025

For the case when InvalidAccessError is thrown when trying to open the port, instead of the suggested NotAllowedError, we can consider InvalidStateError, which has a usage precedent of being used by .send method in the similar case:

If the port is "disconnected", throw an InvalidStateError exception.

@mjwilson-google mjwilson-google self-requested a review December 9, 2025 20:29
svgeesus
svgeesus approved these changes Dec 9, 2025
View reviewed changes
Copy link
Contributor

@svgeesus svgeesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mjwilson-google
mjwilson-google approved these changes Dec 9, 2025
View reviewed changes
Copy link
Contributor

@mjwilson-google mjwilson-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think you are right and NotAllowedError is the best fit for both of these. Thank you.

@mjwilson-google mjwilson-google merged commit ccef7f6 into WebAudio:gh-pages Dec 9, 2025
1 check failed
@mjwilson-google
Copy link
Contributor

mjwilson-google commented Dec 9, 2025

Chromium change here: https://crrev.com/c/7242095

@nikelborm nikelborm mentioned this pull request Dec 9, 2025
Merged
brave-builds pushed a commit to brave/chromium that referenced this pull request Dec 10, 2025
Use NotAllowedError instead of InvalidAccessError in Web MIDI
094a61d 
See WebAudio/web-midi-api#278

The exception type when sysex access is denied has been changed in the
spec to NotAllowedError instead of the deprecated InvalidAccessError.

The exception type was also changed when opening a MIDIPort, but it
looks like Chromium doesn't currently throw an exception in this case
so no update is necessary right now.

Change-Id: Ic80cb39064c8240c6bc00d5f0a7f36e6c7bdd09b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7242095
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Michael Wilson <mjwilson@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1556825}
wbamberg pushed a commit to mdn/content that referenced this pull request Dec 19, 2025
@nikelborm
MIDI APIs now use NotAllowedError instead of InvalidAccessError (#…
ae1080c 
…42334)

MIDI APIs now use NotAllowedError instead of InvalidAccessError

The change in spec: WebAudio/web-midi-api@3795f22
According PR: WebAudio/web-midi-api#278
nikelborm added a commit to nikelborm/firefox that referenced this pull request Dec 19, 2025
@nikelborm
Bug 2007071 - Align MIDI errors with the web-midi-api spec. Deprecate…
21a2174 
…d `SecurityError` and `InvalidAccessError` in favor of `NotAllowedError` r?gsvelto,bholley

= `InvalidAccessError` replaced by `NotAllowedError`:

The change in spec: [WebAudio/web-midi-api@3795f22](WebAudio/web-midi-api@3795f22)
According PR: [WebAudio/web-midi-api#278](WebAudio/web-midi-api#278)
MDN update PR: [mdn/content#42334](mdn/content#42334)

== Affected APIs

1. `.send` method of output MIDI ports
2. `.open` method of MIDI ports

= `SecurityError` replaced by `NotAllowedError`:

The change in spec: [WebAudio/web-midi-api@b7806b8](WebAudio/web-midi-api@b7806b8)
According PR: [WebAudio/web-midi-api#267](WebAudio/web-midi-api#267)
MDN update PR: [mdn/content#41956](mdn/content#41956)

== Affected APIs

1. `navigator.requestMIDIAccess` method
@nikelborm
Copy link
Contributor Author

nikelborm commented Dec 19, 2025 •
edited
Loading

Firefox change:
https://bugzilla.mozilla.org/show_bug.cgi?id=2007071
https://phabricator.services.mozilla.com/D277533

@nikelborm nikelborm mentioned this pull request Dec 19, 2025
Closed
nikelborm added a commit to nikelborm/firefox that referenced this pull request Dec 25, 2025
@nikelborm
Bug 2007071 - Align MIDI errors with the web-midi-api spec. Deprecate…
c5078c9 
…d `SecurityError` and `InvalidAccessError` in favor of `NotAllowedError` r?gsvelto

= `InvalidAccessError` replaced by `NotAllowedError`:

The change in spec: [WebAudio/web-midi-api@3795f22](WebAudio/web-midi-api@3795f22)
According PR: [WebAudio/web-midi-api#278](WebAudio/web-midi-api#278)
MDN update PR: [mdn/content#42334](mdn/content#42334)

== Affected APIs

1. `.send` method of output MIDI ports
2. `.open` method of MIDI ports

= `SecurityError` replaced by `NotAllowedError`:

The change in spec: [WebAudio/web-midi-api@b7806b8](WebAudio/web-midi-api@b7806b8)
According PR: [WebAudio/web-midi-api#267](WebAudio/web-midi-api#267)
MDN update PR: [mdn/content#41956](mdn/content#41956)

== Affected APIs

1. `navigator.requestMIDIAccess` method
nikelborm added a commit to nikelborm/firefox that referenced this pull request Dec 25, 2025
@nikelborm
Bug 2007071 - Align MIDI errors with the web-midi-api spec. Deprecate…
e0de00f 
…d `SecurityError` and `InvalidAccessError` in favor of `NotAllowedError` r?gsvelto

= `InvalidAccessError` replaced by `NotAllowedError`:

The change in spec: [WebAudio/web-midi-api@3795f22](WebAudio/web-midi-api@3795f22)
According PR: [WebAudio/web-midi-api#278](WebAudio/web-midi-api#278)
MDN update PR: [mdn/content#42334](mdn/content#42334)

== Affected APIs

1. `.send` method of output MIDI ports
2. `.open` method of MIDI ports

= `SecurityError` replaced by `NotAllowedError`:

The change in spec: [WebAudio/web-midi-api@b7806b8](WebAudio/web-midi-api@b7806b8)
According PR: [WebAudio/web-midi-api#267](WebAudio/web-midi-api#267)
MDN update PR: [mdn/content#41956](mdn/content#41956)

== Affected APIs

1. `navigator.requestMIDIAccess` method
nikelborm added a commit to nikelborm/firefox that referenced this pull request Dec 25, 2025
@nikelborm
Bug 2007071 - Align MIDI errors with the web-midi-api spec. Deprecate…
9defbe0 
…d `SecurityError` and `InvalidAccessError` in favor of `NotAllowedError` r=gsvelto

= `InvalidAccessError` replaced by `NotAllowedError`:

The change in spec: [WebAudio/web-midi-api@3795f22](WebAudio/web-midi-api@3795f22)
According PR: [WebAudio/web-midi-api#278](WebAudio/web-midi-api#278)
MDN update PR: [mdn/content#42334](mdn/content#42334)

== Affected APIs

1. `.send` method of output MIDI ports
2. `.open` method of MIDI ports

= `SecurityError` replaced by `NotAllowedError`:

The change in spec: [WebAudio/web-midi-api@b7806b8](WebAudio/web-midi-api@b7806b8)
According PR: [WebAudio/web-midi-api#267](WebAudio/web-midi-api#267)
MDN update PR: [mdn/content#41956](mdn/content#41956)

== Affected APIs

1. `navigator.requestMIDIAccess` method
nikelborm added a commit to nikelborm/firefox that referenced this pull request Dec 25, 2025
@nikelborm
Bug 2007071 - Align MIDI errors with the web-midi-api spec. Deprecate…
edd9946 
…d `SecurityError` and `InvalidAccessError` in favor of `NotAllowedError` r=gsvelto

= `InvalidAccessError` replaced by `NotAllowedError`:

The change in spec: [WebAudio/web-midi-api@3795f22](WebAudio/web-midi-api@3795f22)
According PR: [WebAudio/web-midi-api#278](WebAudio/web-midi-api#278)
MDN update PR: [mdn/content#42334](mdn/content#42334)

== Affected APIs

1. `.send` method of output MIDI ports
2. `.open` method of MIDI ports

= `SecurityError` replaced by `NotAllowedError`:

The change in spec: [WebAudio/web-midi-api@b7806b8](WebAudio/web-midi-api@b7806b8)
According PR: [WebAudio/web-midi-api#267](WebAudio/web-midi-api#267)
MDN update PR: [mdn/content#41956](mdn/content#41956)

== Affected APIs

1. `navigator.requestMIDIAccess` method

Differential Revision: https://phabricator.services.mozilla.com/D277533
nikelborm added a commit to nikelborm/firefox that referenced this pull request Dec 25, 2025
@nikelborm
Bug 2007071 - Align MIDI errors with the web-midi-api spec. Deprecate…
2e94450 
…d `SecurityError` and `InvalidAccessError` in favor of `NotAllowedError` r=gsvelto

= `InvalidAccessError` replaced by `NotAllowedError`:

The change in spec: [WebAudio/web-midi-api@3795f22](WebAudio/web-midi-api@3795f22)
According PR: [WebAudio/web-midi-api#278](WebAudio/web-midi-api#278)
MDN update PR: [mdn/content#42334](mdn/content#42334)

== Affected APIs

1. `.send` method of output MIDI ports
2. `.open` method of MIDI ports

= `SecurityError` replaced by `NotAllowedError`:

The change in spec: [WebAudio/web-midi-api@b7806b8](WebAudio/web-midi-api@b7806b8)
According PR: [WebAudio/web-midi-api#267](WebAudio/web-midi-api#267)
MDN update PR: [mdn/content#41956](mdn/content#41956)

== Affected APIs

1. `navigator.requestMIDIAccess` method

Differential Revision: https://phabricator.services.mozilla.com/D277533
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@svgeesus svgeesus svgeesus approved these changes

@mjwilson-google mjwilson-google mjwilson-google approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nikelborm @mjwilson-google @svgeesus