Solver: avoid failing when nullable columns & Fix column name in join#1476
Open
agusaldasoro wants to merge 7 commits intomasterfrom
Open
Solver: avoid failing when nullable columns & Fix column name in join#1476agusaldasoro wants to merge 7 commits intomasterfrom
agusaldasoro wants to merge 7 commits intomasterfrom
Conversation
agusaldasoro
commented
Mar 18, 2026
core/src/main/kotlin/org/evomaster/core/solver/SMTLibZ3DbConstraintSolver.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/evomaster/core/solver/SMTConditionVisitor.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Agustina Aldasoro <agusaldasoro@users.noreply.github.com>
Add more supported types and fix join column name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and bug fixes to the SMT-LIB generation and SQL parsing logic, particularly around handling SQL conditions, foreign key resolution, and database type mappings. The changes add support for the
<>(not equals) operator, improve robustness when parsing SQL (especially with nulls and type mismatches), and expand coverage for more database column types. Tests have also been added to ensure correct handling of these scenarios.SQL condition handling and parsing improvements:
<>(not equals) SQL operator in both the AST and the parser, allowing such conditions to be correctly translated into SMT-LIB assertions. [1] [2] [3]SMTConditionVisitorto gracefully handle SQL conditions involvingNULLby skipping them, and to better manage empty sub-conditions in AND/OR expressions. [1] [2] [3] [4]SMT-LIB generator robustness:
Foreign key and column type mapping:
INT2,INT4,INT8,NUMERIC,BOOL,UUID,JSONB,BYTEA). [1] [2]Testing:
<>(not equals) conditions and to ensure that NULL comparisons are skipped, with only valid constraints emitted. [1] [2]