Conversation
kentbull
force-pushed
the
equality-check-cleanup
branch
from
June 26, 2026 23:45
9b6c490 to
2790a64
Compare
iFergal
reviewed
Jul 9, 2026
iFergal
left a comment
iFergal
left a comment
Collaborator
There was a problem hiding this comment.
Just one small comment, everything else is great!
| * Ed25519 implementation behind `sign`. | ||
| * | ||
| * Prefer `sign()` for normal use; this method expects the caller to supply | ||
| * the seed and verifier that match this signing suite. |
Collaborator
There was a problem hiding this comment.
imo we should make _ed25519 private and remove this comment, better if never called externally
Collaborator
|
also need to format this PR |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were a few equality checks that would possibly coerce values in an unexpected way. This PR changes double equals
==to explicit triple equals===that do not do type coercion. The new tests exercise the new invalid index and ondex checks.It also adds thorough docs to the Signer class.