Skip to content

macOS: skip VPN reconnect on same-SSID WiFi AP roams #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Safibulae wants to merge 1 commit into
base: master
Choose a base branch
from
Open

macOS: skip VPN reconnect on same-SSID WiFi AP roams #310

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/client/engine/engine/networkdetectionmanager/networkdetectionmanager_mac.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,11 @@ void NetworkDetectionManager_mac::onNetworkStateChanged()

if (networkInterface != lastNetworkInterface_)
{
bool significantChange = false;

if (networkInterface.interfaceName != lastNetworkInterface_.interfaceName)
{
significantChange = true;
if (networkInterface.interfaceIndex == -1)
{
qCInfo(LOG_BASIC) << "Primary Adapter down: " << lastNetworkInterface_.interfaceName;
Expand All @@ -62,6 +65,7 @@ void NetworkDetectionManager_mac::onNetworkStateChanged()
}
else if (networkInterface.networkOrSsid != lastNetworkInterface_.networkOrSsid)
{
significantChange = true;
qCInfo(LOG_BASIC) << "Primary Network Changed: "
<< networkInterface.interfaceName
<< " : " << networkInterface.networkOrSsid;
Expand All @@ -75,12 +79,14 @@ void NetworkDetectionManager_mac::onNetworkStateChanged()
}
else
{
qCInfo(LOG_BASIC) << "Unidentified interface change";
// Can happen when changing interfaces
qCInfo(LOG_BASIC) << "Minor interface change on" << networkInterface.interfaceName
<< "(e.g. same-SSID AP roam), skipping reconnect";
}

lastNetworkInterface_ = networkInterface;
emit networkChanged(networkInterface);
if (significantChange) {
emit networkChanged(networkInterface);
}
}
else if (wifiAdapterUp != lastWifiAdapterUp_)
{
Expand Down