Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
desrosj
added this pull request to stack #82927
September 15, 2026 17:28
desrosj
marked this pull request as ready for review
September 15, 2026 17:28
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This was referenced Sep 18, 2026
desrosj
removed this pull request from stack #82927
September 21, 2026 15:45
desrosj
added this pull request to stack #83282
September 21, 2026 15:45
desrosj
removed this pull request from stack #83282
September 21, 2026 18:43
desrosj
changed the base branch from
fix-actions-6.6/fix-playwright-noble-install
to
wp/6.6
September 21, 2026 18:44
desrosj
force-pushed
the
fix-actions-6.6/pin-performance-tests-wp-version
branch
from
September 21, 2026 18:54
f688c0e to
1f44045
Compare
github-actions
Bot
added
[Tool] WP Scripts
desrosj
changed the base branch from
wp/6.6
to
fix-actions-6.6/fix-playwright-noble-install
September 21, 2026 18:55
desrosj
added this pull request to stack #83289
September 21, 2026 18:55
|
Size Change: 0 B Total Size: 1.73 MB ℹ️ View Unchanged
|
desrosj
removed this pull request from stack #83289
September 22, 2026 17:08
desrosj
changed the base branch from
fix-actions-6.6/fix-playwright-noble-install
to
wp/6.6
September 22, 2026 17:08
desrosj
force-pushed
the
fix-actions-6.6/pin-performance-tests-wp-version
branch
from
September 22, 2026 17:10
1f44045 to
3beeb7b
Compare
github-actions
Bot
removed
[Tool] WP Scripts
desrosj
changed the base branch from
wp/6.6
to
fix-actions-6.6/remove-mobile-unit-js-job
September 22, 2026 17:11
desrosj
added this pull request to stack #83396
September 22, 2026 17:11
…h-triggered tasks (`add-milestone`, `first-time-contributor-account-link`) both bail out immediately outside of `trunk`, so running them here on every push does nothing.
desrosj
force-pushed
the
fix-actions-6.6/pin-performance-tests-wp-version
branch
from
October 7, 2026 14:18
ce73652 to
a3a439b
Compare
desrosj
force-pushed
the
fix-actions-6.6/remove-mobile-unit-js-job
branch
from
October 7, 2026 14:18
3537847 to
8445ee3
Compare
desrosj
removed this pull request from stack #83644
October 7, 2026 18:12
desrosj
changed the base branch from
fix-actions-6.6/remove-mobile-unit-js-job
to
wp/6.6
October 7, 2026 18:13
Member
Author
|
Closing: the performance tests workflow is removed from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Two changes to the
pull_requestperformance comparison step in.github/workflows/performance.yml:GITHUB_BASE_REFenvironment variable, instead of a hard-codedtrunk.Why?
The version pin. While the
.wp-env.jsonfile pins Core asWordPress/WordPress#6.6-branch, the performance testing workflow builds it's own, separate.wp-env.jsonfile for each run and only pins a specific version of Core when a--wp-versionargument is explicitly passed.Because this was missing, the workflow silently fell back to using
trunk. This causes the test suite to fail because the underlying architecture for a number of components has changed significantly over time.The base branch and step name. Comparing a frozen release branch against
trunkmeasures unrelated changes. Upstream made this change in #66196 ("Performance tests tooling : Compare performance with correct branch", October 2024), after this branch was cut. "Compare performance with base branch" is the name the same step has used ontrunksince then.Upstream's change passes the base branch as an inline
${{ github.base_ref }}expression. This reads it from theGITHUB_BASE_REFenvironment variable instead, matching upstream's later conversion of this workflow (a93c6c9f, "Replace inline expressions with environment variables."), and keeps the shell arguments quoted.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code