Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
desrosj
added this pull request to stack #83006
September 16, 2026 00:34
This was referenced Sep 16, 2026
Closed
Closed
Closed
desrosj
removed this pull request from stack #83006
September 21, 2026 15:45
desrosj
added this pull request to stack #83283
September 21, 2026 15:45
desrosj
removed this pull request from stack #83283
September 21, 2026 18:44
desrosj
changed the base branch from
fix-actions-6.5/fix-flaky-e2e-tests
to
wp/6.5
September 21, 2026 18:45
desrosj
force-pushed
the
fix-actions-6.5/pin-wp-version-performance-testing
branch
from
September 21, 2026 18:52
e0b06d8 to
1789e1c
Compare
github-actions
Bot
added
[Tool] WP Scripts
desrosj
changed the base branch from
wp/6.5
to
fix-actions-6.5/fix-flaky-e2e-tests
September 21, 2026 18:53
desrosj
added this pull request to stack #83288
September 21, 2026 18:53
|
Size Change: 0 B Total Size: 1.72 MB ℹ️ View Unchanged
|
desrosj
removed this pull request from stack #83288
September 21, 2026 23:45
desrosj
changed the base branch from
fix-actions-6.5/fix-flaky-e2e-tests
to
wp/6.5
September 21, 2026 23:46
desrosj
force-pushed
the
fix-actions-6.5/pin-wp-version-performance-testing
branch
from
September 21, 2026 23:48
1789e1c to
ccef0c1
Compare
desrosj
changed the base branch from
wp/6.5
to
fix-actions-6.5/fix-flaky-e2e-tests
September 21, 2026 23:52
desrosj
added this pull request to stack #83302
September 21, 2026 23:52
desrosj
removed this pull request from stack #83302
September 22, 2026 17:11
desrosj
changed the base branch from
fix-actions-6.5/fix-flaky-e2e-tests
to
wp/6.5
September 22, 2026 17:12
desrosj
force-pushed
the
fix-actions-6.5/pin-wp-version-performance-testing
branch
from
September 22, 2026 17:13
ccef0c1 to
60340e0
Compare
…h-triggered tasks (`add-milestone`, `first-time-contributor-account-link`) both bail out immediately outside of `trunk`, so running them here on every push does nothing.
desrosj
force-pushed
the
fix-actions-6.5/pin-wp-version-performance-testing
branch
from
October 7, 2026 14:19
61ced1c to
b1ba84f
Compare
desrosj
force-pushed
the
fix-actions-6.5/remove-mobile-unit-js-job
branch
from
October 7, 2026 14:19
6fafe58 to
865afe4
Compare
desrosj
removed this pull request from stack #83740
October 7, 2026 18:12
desrosj
changed the base branch from
fix-actions-6.5/remove-mobile-unit-js-job
to
wp/6.5
October 7, 2026 18:12
Member
Author
|
Closing: the performance tests workflow is removed from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82928.
What?
Two changes to the
pull_requestperformance comparison step in.github/workflows/performance.yml:GITHUB_BASE_REFenvironment variable, instead of a hard-codedtrunk.Why?
The version pin. While the
.wp-env.jsonfile pins Core asWordPress/WordPress#6.5-branch, the performance testing workflow builds it's own, separate.wp-env.jsonfile for each run and only pins a specific version of Core when a--wp-versionargument is explicitly passed.Because this was missing, the workflow silently fell back to using
trunk. This causes the test suite to fail because the underlying architecture for a number of components has changed significantly over time.The base branch and step name. Comparing a frozen release branch against
trunkmeasures unrelated changes. Upstream made this change in #66196 ("Performance tests tooling : Compare performance with correct branch", October 2024), after this branch was cut. "Compare performance with base branch" is the name the same step has used ontrunksince then.Upstream's change passes the base branch as an inline
${{ github.base_ref }}expression. This reads it from theGITHUB_BASE_REFenvironment variable instead, matching upstream's later conversion of this workflow (a93c6c9f, "Replace inline expressions with environment variables."), and keeps the shell arguments quoted.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code