Skip to content

bump workflows for 6.9 #10583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aaronjorbin wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

bump workflows for 6.9 #10583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file added .github/phpunit-matrix.js
View file
Open in desktop
Copy link
Member

@desrosj desrosj Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this included on accident?

Empty file.
2 changes: 1 addition & 1 deletion .github/workflows/test-old-branches.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ on:
permissions: {}

env:
CURRENTLY_SUPPORTED_BRANCH: '6.8'
CURRENTLY_SUPPORTED_BRANCH: '6.9'

jobs:
dispatch-workflows-for-old-branches:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/upgrade-develop-testing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ jobs:
db-type: [ 'mysql' ]
db-version: [ '5.7', '8.4' ]
# WordPress 4.9 is the oldest version that supports PHP 7.2.
wp: [ '4.9', '6.7', '6.8', '6.9-RC1' ]
wp: [ '4.9', '6.7', '6.8', '6.9' ]
Copy link
Member

@desrosj desrosj Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
wp: [ '4.9', '6.7', '6.8', '6.9' ]
wp: [ '4.9', '6.8', '6.9' ]

I believe that the intention here was to test the currently supported branch +1 previous. @johnbillion can you confirm that?

We should add a docblock similar to the one in upgrade-testing.yml explaining the ideal strategy matrix for our future selves.

multisite: [ false, true ]

exclude:
Expand Down Expand Up @@ -102,7 +102,7 @@ jobs:
db-type: [ 'mysql' ]
db-version: [ '8.4' ]
# WordPress 4.9 is the oldest version that supports PHP 7.2.
Copy link
Member

@desrosj desrosj Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# WordPress 4.9 is the oldest version that supports PHP 7.2.

Possibly worth a separate ticket/PR, but this is not seem here after d836928. Adding 4.9 back to the matrix may also be reasonable. That would change the number of spawned jobs from 4 to 6.

Also, the 7.2 value for php should be removed. This would make the exclude statement necessary because

wp: [ '6.7', '6.8' ]
wp: [ '6.8', '6.9' ]
multisite: [ false, true ]

exclude:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/upgrade-testing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ jobs:
php: [ '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4', '8.5' ]
db-type: [ 'mysql' ]
db-version: [ '5.7', '8.0', '8.4', '9.5' ]
wp: [ '6.7', '6.8' ]
wp: [ '6.8', '6.9' ]
multisite: [ false, true ]

exclude:
Expand Down
Loading