Skip to content

Themes: Reset update notice when credentials modal is canceled - #12033

Open
ArkaPrabhaChowdhury wants to merge 6 commits into
WordPress:trunkfrom
ArkaPrabhaChowdhury:trac-37669-theme-update-cancel
Open

Themes: Reset update notice when credentials modal is canceled#12033
ArkaPrabhaChowdhury wants to merge 6 commits into
WordPress:trunkfrom
ArkaPrabhaChowdhury:trac-37669-theme-update-cancel

Conversation

@ArkaPrabhaChowdhury

@ArkaPrabhaChowdhury ArkaPrabhaChowdhury commented Jun 1, 2026

Copy link
Copy Markdown

Summary

  • restore the theme details popup notice when the filesystem credentials modal is canceled
  • add a QUnit regression test for the queued theme update cancel flow

Testing

  • vendor/bin/phpcbf --standard=phpcs.xml.dist src/js/_enqueues/wp/updates.js tests/qunit/wp-admin/js/updates.js
  • vendor/bin/phpcs --standard=phpcs.xml.dist src/js/_enqueues/wp/updates.js tests/qunit/wp-admin/js/updates.js
  • npx tsc --build
  • npx playwright test --config tests/qunit/playwright.config.js

Trac ticket: https://core.trac.wordpress.org/ticket/37669

Use of AI Tools

AI assistance: Yes
Tool(s): OpenAI Codex
Model(s): GPT-5
Used for: Reviewing the Trac ticket and relevant code, helping with the initial implementation and regression-test approach, and assisting with validation and PR-description drafting. The final implementation, tests, validation results, and description were reviewed and accepted by me.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@ArkaPrabhaChowdhury
ArkaPrabhaChowdhury marked this pull request as ready for review June 1, 2026 14:23
@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props arkaprabhachowdhury.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant