Upgrade/Install: Restore the sync package files in the $_old_files array. - #13061
Draft
t-hamano wants to merge 1 commit into
Draft
Upgrade/Install: Restore the sync package files in the $_old_files array.#13061t-hamano wants to merge 1 commit into
$_old_files array.#13061t-hamano wants to merge 1 commit into
Conversation
…array. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wp-includes/js/dist/sync.jsandsync.min.jswere removed in 7.0.2, but came back in 7.1. This was not intentional.The two paths are currently commented out in
$_old_fileswith a "Restored in WordPress 7.1." note. This PR restores them as active entries so that upgrading to 7.1 deletes the leftover files.Order of operations
These steps must be done in this order. Otherwise
$_old_fileswill not match what is actually shipped.wp/7.1branch.7.1branch of wordpress-develop, update the pinned Gutenberg hash to the latest commit of thewp/7.1branch.sync.jsandsync.min.jsthen disappear from core, andwp.syncis no longer exposed.Trac ticket: https://core.trac.wordpress.org/ticket/65813
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5
Used for: Investigating when and why the files were reintroduced, and drafting this description. The change itself is a two-line edit that I reviewed and take responsibility for.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.