Skip to content

Removes ignored errors from 4 phpstan baseline files and fixes their errors - #13069

Open
dpanta94 wants to merge 2 commits into
WordPress:trunkfrom
dpanta94:fix/phpstan-baselines.1
Open

Removes ignored errors from 4 phpstan baseline files and fixes their errors#13069
dpanta94 wants to merge 2 commits into
WordPress:trunkfrom
dpanta94:fix/phpstan-baselines.1

Conversation

@dpanta94

@dpanta94 dpanta94 commented Aug 16, 2026

Copy link
Copy Markdown

Removes in total 104 errors

Removes errors from the below phpstan baselines and fixes the issues that they were covering:

  • deadCode.unreachable.neon
  • if.alwaysTrue.neon
  • while.alwaysFalse.neon
  • while.alwaysTrue.neon

How ?

Marks the have_comments() and have_posts() methods as impure since they can change their return type based on the state of a speficic WP_Query instance or the global's WP_Query instance.

In the file src/wp-content/themes/twentyfourteen/inc/widgets.php moves the $tmp_more definition out of the while loop $ephemera->have_posts(). This was a bug, since it would guarantee that GLOBALS['more'] and the $tmp_more would be overwritten to 0 if there were at least 2 loops.

Loom showing the bug https://www.loom.com/share/c713c48d553b4e6abfdb3e2b9b5f2cf7

Trac ticket: https://core.trac.wordpress.org/ticket/65817

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Opus 5
Used for: Help with suggesting how to fix the phpstan output for the specific errors we are removing the baselines for. The actual result has been reviewed and are owned by me.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@dpanta94
dpanta94 force-pushed the fix/phpstan-baselines.1 branch from c126a52 to 28772c5 Compare August 16, 2026 17:38
@dpanta94
dpanta94 marked this pull request as ready for review August 16, 2026 17:48
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props dpantazis.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@dpanta94 dpanta94 changed the title feat: removes 4 phpstan baseline files and fixes their errors Removes 4 phpstan baseline files and fixes their errors Aug 16, 2026
@dpanta94 dpanta94 changed the title Removes 4 phpstan baseline files and fixes their errors Removes ignored errors from 4 phpstan baseline files and fixes their errors Aug 16, 2026
@dpanta94
dpanta94 force-pushed the fix/phpstan-baselines.1 branch from 279f0e2 to 4459ea8 Compare August 16, 2026 18:59
More specifically removes baselines deadCode.unreachable.neon, if.alwaysTrue.neon, while.alwaysFalse.neon and while.alwaysTrue.neon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant