reject traversal in wp_delete_file_from_directory stream paths - #13131
reject traversal in wp_delete_file_from_directory stream paths#13131nvxbug wants to merge 1 commit into
Conversation
Trac Ticket MissingThis pull request is missing a link to a Trac ticket. For a contribution to be considered, there must be a corresponding ticket in Trac. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. More information about contributing to WordPress on GitHub can be found in the Core Handbook. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @nvxbug. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
wp_delete_file_from_directory()resolves paths withrealpath()before the containment check, butrealpath()does not support stream wrappers, so the stream branch keeps the path as-is andwp_normalize_path()only collapses slashes without resolving... A stream path such ass3://bucket/uploads/../../secret/keys.jsontherefore still passesstr_starts_with()against the uploads base, and the wrapper walks back out of the directory when the delete runs. On stream-backed uploads (for example an S3 offload plugin where$uploadpath['basedir']iss3://bucket/uploads), the attachment-meta delete path inwp_delete_attachment()reaches this with an attacker-controlled_wp_attached_filevalue.Reject any
..path segment on the normalized path before the prefix check.realpath()already strips those segments for real files, so this only tightens the stream branch and leaves valid paths unchanged, including filenames that merely contain dots. Keeping the guard in the callee means the severalwp_delete_attachment()call sites don't each need their own check.Trac ticket:
Use of AI Tools
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.