Skip to content

reject traversal in wp_delete_file_from_directory stream paths - #13131

Open
nvxbug wants to merge 1 commit into
WordPress:trunkfrom
nvxbug:delete-file-stream-traversal
Open

reject traversal in wp_delete_file_from_directory stream paths#13131
nvxbug wants to merge 1 commit into
WordPress:trunkfrom
nvxbug:delete-file-stream-traversal

Conversation

@nvxbug

@nvxbug nvxbug commented Aug 18, 2026

Copy link
Copy Markdown

wp_delete_file_from_directory() resolves paths with realpath() before the containment check, but realpath() does not support stream wrappers, so the stream branch keeps the path as-is and wp_normalize_path() only collapses slashes without resolving ... A stream path such as s3://bucket/uploads/../../secret/keys.json therefore still passes str_starts_with() against the uploads base, and the wrapper walks back out of the directory when the delete runs. On stream-backed uploads (for example an S3 offload plugin where $uploadpath['basedir'] is s3://bucket/uploads), the attachment-meta delete path in wp_delete_attachment() reaches this with an attacker-controlled _wp_attached_file value.

Reject any .. path segment on the normalized path before the prefix check. realpath() already strips those segments for real files, so this only tightens the stream branch and leaves valid paths unchanged, including filenames that merely contain dots. Keeping the guard in the callee means the several wp_delete_attachment() call sites don't each need their own check.

Trac ticket:

Use of AI Tools


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

Copy link
Copy Markdown

Trac Ticket Missing

This pull request is missing a link to a Trac ticket. For a contribution to be considered, there must be a corresponding ticket in Trac.

To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. More information about contributing to WordPress on GitHub can be found in the Core Handbook.

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @nvxbug.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant