REST API: Split comma-separated methods given in an array - #13134
REST API: Split comma-separated methods given in an array#13134itzmekhokan wants to merge 1 commit into
Conversation
`WP_REST_Server::register_route()` accepts the `methods` argument as either a string or an array, but only the string form was split on commas. An array element containing one, such as the multi-method `WP_REST_Server::EDITABLE` constant, became a single unmatchable method key, so `array( READABLE, EDITABLE )` registered a route where POST, PUT and PATCH returned 404 with no notice at registration time. Split each array element as well, so both forms register the same route. A comma is a delimiter in the RFC 9110 token grammar, so no valid method name can contain one. Fixes #65905.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
1 participant
Registering a REST route with
'methods' => array( WP_REST_Server::READABLE, WP_REST_Server::EDITABLE )returns 404 for POST, PUT and PATCH.WP_REST_Server::get_routes()splits themethodsargument on commas only when it is a string. An array element containing one, such as the multi-methodEDITABLEconstant, becomes a single method key that no request can match, with no notice at registration. The patch splits each array element too, so both forms register the same route.The
Allowheader is unchanged — it reassembles the key by imploding on commas, which is why the mismatch stayed invisible.Trac ticket: https://core.trac.wordpress.org/ticket/65905
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5
Used for: Reproducing the failure against trunk, measuring the array and string forms side by side, and drafting the regression test. All changes were reviewed and validated by me.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.