Administration: Underline the in-text links in the Activity widget - #13357
Administration: Underline the in-text links in the Activity widget#13357itzmekhokan wants to merge 2 commits into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
joedolson
left a comment
joedolson
left a comment
There was a problem hiding this comment.
I think there's a more efficient change.
| color: #646970; | ||
| } | ||
|
|
||
| #latest-comments #the-comment-list .comment-meta a { |
There was a problem hiding this comment.
Let's not add new selectors here. I think it would be better to add this context as an exclusion on line 1069, above, so that the decoration isn't unset.
There was a problem hiding this comment.
| #dashboard-widgets li:not(.comment) a, |
In the Recent Comments section of the Activity dashboard widget, the comment author and post links sit inside a sentence and were distinguished from the surrounding text by color alone, which fails WCAG SC 1.4.1 Use of Color. `#dashboard-widgets li a` removes the underline from every link in a dashboard widget list item. Restore it for the links inside `.comment-meta`, leaving the row action and footer links, which are distinguishable by context, unchanged. Fixes #66017.
6240cc8 to
0891dd2
Compare
|
I pushed a commit to use 
|
…guished from surrounding text. Links within blocks of text must be distinguished in a way that does not rely on color. Developed in #13357 Props khokansardar, afercia, joedolson. Fixes #66017. git-svn-id: https://develop.svn.wordpress.org/trunk@63536 602fd350-edb4-49c9-b593-d223f7449a82
…guished from surrounding text. Links within blocks of text must be distinguished in a way that does not rely on color. Developed in WordPress/wordpress-develop#13357 Props khokansardar, afercia, joedolson. Fixes #66017. Built from https://develop.svn.wordpress.org/trunk@63536 git-svn-id: http://core.svn.wordpress.org/trunk@62712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
3 participants
In the Activity dashboard widget, the comment author and post links sit inside a sentence and are distinguished from the surrounding text by color alone, which axe-core reports as a
link-in-text-blockviolation.#dashboard-widgets li aremoves the underline from every link inside a dashboard widget list item, including the two links in the.comment-metasentence. This patch restorestext-decoration: underlinefor links within.comment-meta.The row action and footer links, which context already distinguishes as links, are unchanged.
Trac ticket: https://core.trac.wordpress.org/ticket/66017
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5
Used for: Writing PR details. All changes were reviewed and validated by me.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.