Conversation
Four `actions/upload-artifact` steps inherit GitHub's 90-day default retention, which is far longer than any of them are used for. The `wordpress-develop` and `performance-*` artifacts are same-run handoffs, downloaded by a later job in the same workflow run and never read again. The `failures-artifacts*` artifacts are debugging output from failed end-to-end runs that no workflow consumes. The `wordpress-build-*` artifacts are the only ones read across runs, by the performance test baseline lookup in `performance.yml` and by the WordPress Playground previewer, so they keep a longer window. See #65845. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four
actions/upload-artifactsteps inherit GitHub's 90-day default, which is far longerthan any of them are used for. This sets an explicit
retention-dayson each.reusable-build-package.ymlwordpress-developupgrade-tests-developreusable-performance-test-v2.ymlperformance-*comparejobreusable-end-to-end-tests.ymlfailures-artifacts*reusable-test-core-build-process.ymlwordpress-build-*reusable-prepare-gutenberg.ymlalready setsretention-days: 7and is unchanged.Why
Three of the four are retained long after anything can read them:
wordpress-developandperformance-*are same-run handoffs. Each is downloaded by alater job in the same workflow run and never read again, but both currently sit for 90
days. Every copy older than its own run is dead weight.
failures-artifacts*is debugging output from failed end-to-end runs. No workflowconsumes it, and its value to a human drops off quickly after the run fails.
wordpress-build-*is the only one read across runs, so it keeps a longer window.This repository currently stores over 214,000 Actions artifacts. Setting retention
explicitly documents how long each artifact is actually needed instead of inheriting a
default that no one chose, and keeps stored volume proportionate to use.
Notes for reviewers
wordpress-build-*keeps 14 days because it is genuinely read across runs, in twoplaces:
performance.ymllooks upwordpress-build-<sha>to decide whether to run abeforesubject, and WordPress Playground fetcheswordpress-build-<PR#>when someoneopens the preview link posted by
pull-request-comments.yml. Playground previews nowexpire 14 days after a pull request's last push rather than 90; stale pull requests
need a rebase, which Playground's own error message already instructs.
the 1-day artifacts. Re-running all jobs rebuilds them.
Verified with
actionlint(the pinned version fromreusable-workflow-lint.yml): no errors.Trac ticket: https://core.trac.wordpress.org/ticket/65845
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5
Used for: Tracing every artifact producer and consumer across
.github/, verifying whichartifacts are read across workflow runs rather than within one, measuring current artifact
storage via the GitHub API, the four one-line workflow changes, and drafting this
description. I directed the investigation, chose the retention values and scope, and
reviewed the result.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.