Skip to content

Build/Test Tools: Trim the routine PHPUnit database matrix in the 6.8 branch - #13543

Closed
lancewillett wants to merge 1 commit into
WordPress:6.8from
lancewillett:chore/trim-phpunit-db-matrix-6-8
Closed

lancewillett wants to merge 1 commit into
WordPress:6.8from
lancewillett:chore/trim-phpunit-db-matrix-6-8

Conversation

@lancewillett

Copy link
Copy Markdown
Member

Trac ticket: https://core.trac.wordpress.org/ticket/66069

Carries the routine MariaDB trim from r63584 to the 6.8 branch. The MySQL list already matches trunk's routine set.

  • MariaDB: 5.5, 10.6, 10.11, and 11.4 on pushes and pull requests. 10.3, 10.4, and 10.5 run on dispatched runs. 11.8 is not in this branch's list, so it is not added.

Scheduled runs only fire from the default branch, so this keys the full list on workflow_dispatch rather than schedule. test-old-branches.yml dispatches this branch's PHPUnit workflow monthly, so the dropped versions keep running there.

MySQL and MariaDB jobs on a pull request: 87 → 63. Dispatched runs: 87, unchanged.

Validation

  • Expanded both matrices for pull_request and workflow_dispatch, before and after: 87 → 63 and 87 → 87.
  • actionlint and zizmor --persona=regular report the same findings before and after.

Use of AI tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5
Used for: Measuring job counts, the workflow edit, matrix validation, and drafting this description. Reviewed by me.


This pull request is for code review only. Please keep other discussion in the Trac ticket. Do not merge this pull request.

… branch.

Test MariaDB 5.5, 10.6, 10.11, and 11.4 on pushes and pull requests. Dispatched runs, including the monthly run from test-old-branches.yml, keep the full database matrix.

Scheduled runs only fire from the default branch, so on a release branch the dispatch is the equivalent of the weekly full run on trunk. Reduces the MySQL and MariaDB jobs on a pull request from 87 to 63.

Follow-up to [63584].

See #66069.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props lancewillett.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@desrosj desrosj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as on #13540

The changes themselves look fine. However, I find the new syntax to be pretty hard to read. I've opened #13547 to propose a different syntax to accomplish the same thing. Not a hill I am going to die on, but happy for you to at least consider this as a suggestion to improve readability.

And as well as the other PRs:

Is it intentional to not support the full matrix label in this branch?

@lancewillett

Copy link
Copy Markdown
Member Author

#13547

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants