Skip to content

Twenty Twenty-One: Restore search block border in editor for Button inside style - #13546

Open
irozum wants to merge 1 commit into
WordPress:trunkfrom
irozum:fix/63888-twentytwentyone-search-button-inside-editor-border
Open

irozum wants to merge 1 commit into
WordPress:trunkfrom
irozum:fix/63888-twentytwentyone-search-button-inside-editor-border

Conversation

@irozum

@irozum irozum commented Sep 15, 2026

Copy link
Copy Markdown

In the Twenty Twenty-One theme, the Search block's "Button inside" style shows a border around the input/button group on the front end but not in the block editor. The theme's editor styles (_editor.scss) explicitly set border: none on the input for this style, originally relying on the block library's own front-end CSS to draw the border there. A later Gutenberg change (GB41393) lowered the specificity of that block-library rule, so the theme's own border rule now wins on the front end while the editor keeps hiding it — the two views have been out of sync since WordPress 6.1.

Per the ticket discussion, the maintainer team decided the editor should be updated to match the front end (the border has shipped on the front end since 6.1, so removing it now would be more disruptive than keeping it). This PR removes the border: none override in _editor.scss and regenerates the corresponding rule in the compiled style-editor.css, so the editor preview matches the front-end appearance.

Trac ticket: https://core.trac.wordpress.org/ticket/63888

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Sonnet 5
Used for: Implementation and PR description, based on ticket discussion and root-cause analysis in the Trac comments. Verified against a local build with a live before/after comparison in the block editor. Reviewed by Igor Rozum.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props irozum.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant