Repository navigation
Tests: Use assertWPError() for WP_Error assertions in includesPost tests - #13548
Closed
noruzzamans wants to merge 1 commit into
Closed
noruzzamans wants to merge 1 commit into
noruzzamans wants to merge 1 commit into
Conversation
…sts. Replaces generic assertInstanceOf( 'WP_Error' ) assertions with WordPress's dedicated assertWPError() assertion in Tests_Admin_IncludesPost. Follow-up to [25165], [42863], [48937]. See #65819.
noruzzamans
marked this pull request as ready for review
September 16, 2026 03:21
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
wporg-sync
pushed a commit
that referenced
this pull request
Sep 16, 2026
Use the dedicated assertion for the contributor capability checks in _wp_translate_postdata(), matching the existing assertNotWPError() assertions. Retain the explicit error code and message checks. Developed in: #13548 Props noruzzaman. See #65819. git-svn-id: https://develop.svn.wordpress.org/trunk@63637 602fd350-edb4-49c9-b593-d223f7449a82
wporg-sync
pushed a commit
to WordPress/WordPress
that referenced
this pull request
Sep 16, 2026
Use the dedicated assertion for the contributor capability checks in _wp_translate_postdata(), matching the existing assertNotWPError() assertions. Retain the explicit error code and message checks. Developed in: WordPress/wordpress-develop#13548 Props noruzzaman. See #65819. Built from https://develop.svn.wordpress.org/trunk@63637 git-svn-id: http://core.svn.wordpress.org/trunk@62812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces generic
assertInstanceOf( 'WP_Error', ... )assertions intests/phpunit/tests/admin/includesPost.phpwith WordPress's dedicatedassertWPError()assertion.Using dedicated assertion methods improves failure reporting by automatically including the
WP_Errorcode and message in assertion failure outputs.In
Tests_Admin_IncludesPost::test__wp_translate_postdata_cap_checks_contributor(), positive assertions were modernized toassertNotWPError()in [42863]. This update completes modernizing the corresponding error assertions toassertWPError(), bringing full assertion consistency to the test class.This is a test-only change and does not affect runtime behavior.
Background
Follow-up to [25165], [42863], [48937].
Trac ticket: https://core.trac.wordpress.org/ticket/65819
Use of AI Tools
AI assistance: None
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.