Skip to content

Build/QA: Retire booleanOr.alwaysTrue PHPStan baseline #14037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huzaifaalmesbah wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

Build/QA: Retire booleanOr.alwaysTrue PHPStan baseline #14037

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e3be926
HTML API: Annotate WP_HTML_Processor::next_token() as impure for PHPStan
huzaifaalmesbah Oct 6, 2026
a88c45c
Merge remote-tracking branch 'upstream/trunk' into phpstan/retire-boo…
huzaifaalmesbah Oct 10, 2026
2df1e3e
Merge remote-tracking branch 'upstream/trunk' into phpstan/retire-boo…
huzaifaalmesbah Oct 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion phpstan.neon.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ includes:
- tests/phpstan/baselines/booleanNot.alwaysFalse.neon
- tests/phpstan/baselines/booleanNot.alwaysTrue.neon
- tests/phpstan/baselines/booleanOr.alwaysFalse.neon
- tests/phpstan/baselines/booleanOr.alwaysTrue.neon
- tests/phpstan/baselines/class.notFound.neon
- tests/phpstan/baselines/deadCode.unreachable.neon
- tests/phpstan/baselines/empty.offset.neon
Expand Down
2 changes: 2 additions & 0 deletions src/wp-includes/html-api/class-wp-html-processor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -779,6 +779,8 @@ public function next_tag( $query = null ): bool {
* @since 6.7.2 Refactored so subclasses may extend.
*
* @return bool Whether a token was parsed.
*
* @phpstan-impure
*/
public function next_token(): bool {
return $this->next_visitable_token();
Expand Down
5 changes: 0 additions & 5 deletions tests/phpstan/baselines/booleanNot.alwaysTrue.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,6 @@ parameters:
identifier: booleanNot.alwaysTrue
count: 1
path: ../../../src/wp-includes/class-wp-block-templates-registry.php
-
message: '#^Negated boolean expression is always true\.$#'
identifier: booleanNot.alwaysTrue
count: 1
path: ../../../src/wp-includes/class-wp-block.php
-
message: '#^Negated boolean expression is always true\.$#'
identifier: booleanNot.alwaysTrue
Expand Down
25 changes: 0 additions & 25 deletions tests/phpstan/baselines/booleanOr.alwaysTrue.neon
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions tests/phpstan/baselines/deadCode.unreachable.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,6 @@ parameters:
identifier: deadCode.unreachable
count: 1
path: ../../../src/wp-includes/capabilities.php
-
message: '#^Unreachable statement \- code above always terminates\.$#'
identifier: deadCode.unreachable
count: 1
path: ../../../src/wp-includes/class-wp-block.php
-
message: '#^Unreachable statement \- code above always terminates\.$#'
identifier: deadCode.unreachable
Expand Down
Loading