Skip to content

(release/25.2) exa: silence -Wold-style-declaration warning from gcc 16 - #3569

Open
metux wants to merge 1 commit into
release/25.2from
pr/release/25.2-exa-silence-wold-style-declaration-warning-from-gcc-16-_2026-08-20_15-42-17
Open

(release/25.2) exa: silence -Wold-style-declaration warning from gcc 16#3569
metux wants to merge 1 commit into
release/25.2from
pr/release/25.2-exa-silence-wold-style-declaration-warning-from-gcc-16-_2026-08-20_15-42-17

Conversation

@metux

@metux metux commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Backport of #3553 (master)

exa/exa_accel.c:239:1: warning: ‘inline’ is not at beginning of declaration
[-Wold-style-declaration]
239 | static Bool inline
| ^~~~~~

Signed-off-by: Alan Coopersmith alan.coopersmith@oracle.com
Part-of: https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/2272

@metux metux self-assigned this Aug 20, 2026
@metux
metux requested a review from a team August 20, 2026 13:44
metux pushed a commit that referenced this pull request Aug 20, 2026
exa/exa_accel.c:239:1: warning: ‘inline’ is not at beginning of declaration
 [-Wold-style-declaration]
  239 | static Bool inline
      | ^~~~~~

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/2272>
PR: #3569
@metux metux added the bot-review-passed Automated bot review found no blocking issues label Aug 20, 2026
@metux

metux commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

🤖 Automated review — generated by Starfleet ship Voyager on behalf of @metux. Not a human review.

Trivial one-liner — moves inline to the standard position (static inline Bool instead of static Bool inline) to silence a -Wold-style-declaration warning from GCC 16. No functional change; static function, not exported. ABI-safe. Correct fix.

exa/exa_accel.c:239:1: warning: ‘inline’ is not at beginning of declaration
 [-Wold-style-declaration]
  239 | static Bool inline
      | ^~~~~~

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/2272>
@metux
metux force-pushed the pr/release/25.2-exa-silence-wold-style-declaration-warning-from-gcc-16-_2026-08-20_15-42-17 branch from 5b246d0 to b641cbd Compare August 24, 2026 12:01
metux pushed a commit that referenced this pull request Aug 25, 2026
exa/exa_accel.c:239:1: warning: ‘inline’ is not at beginning of declaration
 [-Wold-style-declaration]
  239 | static Bool inline
      | ^~~~~~

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/2272>
PR: #3569
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot-review-passed Automated bot review found no blocking issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants