Skip to content

(release/25.0) darwin: Set thread priorities to user interactive or user initiated as appropriate - #3605

Merged
metux merged 1 commit into
release/25.0from
pr/release/25.0-darwin-set-thread-priorities-to-user-interactive-or-user-initiated-as-appropriate-_2026-08-20_16-24-33
Aug 24, 2026
Merged

metux merged 1 commit into
release/25.0from
pr/release/25.0-darwin-set-thread-priorities-to-user-interactive-or-user-initiated-as-appropriate-_2026-08-20_16-24-33

Conversation

@metux

@metux metux commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Backport of #3557 (master)

Signed-off-by: Jeremy Huddleston Sequoia jeremyhu@apple.com

…s appropriate

Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
@metux metux self-assigned this Aug 20, 2026
@metux
metux requested a review from a team August 20, 2026 14:26
metux pushed a commit that referenced this pull request Aug 20, 2026
…initiated as appropriate

Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
PR: #3605
@metux

metux commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

🤖 Automated review — generated by Starfleet ship Discovery on behalf of @metux. Not a human review.

Same Darwin QoS fix as #3573, now on release/25.0 — no objections.

What it does: sets macOS thread QoS classes via pthread_attr_set_qos_class_np at thread creation time, identical to #3573. QOS_CLASS_USER_INTERACTIVE for startup and input threads, QOS_CLASS_USER_INITIATED for worker threads. Runtime availability guarded by weak-symbol check. Darwin-only, #ifdef __APPLE__ in os/inputthread.c.

ABI impact: none. Darwin-only.

Backport candidate: no. Performance/scheduling improvement, not a correctness or security fix.

Verdict: passes review.

@metux metux added the bot-review-passed Automated bot review found no blocking issues label Aug 20, 2026
@metux
metux merged commit 8e8c423 into release/25.0 Aug 24, 2026
@metux
metux deleted the pr/release/25.0-darwin-set-thread-priorities-to-user-interactive-or-user-initiated-as-appropriate-_2026-08-20_16-24-33 branch August 24, 2026 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot-review-passed Automated bot review found no blocking issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants