Repository navigation
fix(scripts): release an alias twin's local-part netid when it folds - #4991
Merged
Merged
Conversation
ycs-ylabs-maintenance
temporarily deployed
to
fix/alias-twin-release-netid - yalelabs-beta PR #4991
October 11, 2026 20:39 — with
Render
Destroyed
There was a problem hiding this comment.
Approved automatically: the author holds the Admin repository role (#4512).
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4990, refs #4988.
Applying #4990 on Development folded the 3 alias-twin researchers, and
accounts:merge-local-part-netid-twinsthen refused all 3 account pairs asresearcher-identifier-holds-local-part: each archived twin still held the email local part asidentifiers.netid.identifiers.netidalong withaccountId.The netid resolver (
defaultResolveResearcherIdByNetid) does not skip archived researchers, so a twin still holding the alias keeps answering for it.Measured on Development: no real researcher received it in the fix(scrapers): resolve an alias-keyed user to the real account and fold alias-twin researchers #4990 apply.
Data operation
The 3 twins archived by the #4990 apply are already out of the fold's reach, so their local-part
identifiers.netidis unset directly, which is the write this change makes for every later fold, beforeaccounts:merge-local-part-netid-twins --applyruns on Development.