Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
clippy found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
onenewcode
force-pushed
the
dev
branch
5 times, most recently
from
ec21c79 to
7fa85f7
Compare
onenewcode
force-pushed
the
dev
branch
4 times, most recently
from
e754707 to
ab65dfa
Compare
| pub dr: MaybeDyn<usize>, | ||
| } | ||
|
|
||
| impl<H: Hardware> Args<H> { |
Check warning
Code scanning / clippy
associated function `new_null` is never used
|
|
||
| impl<H: Hardware> Args<H> { | ||
| #[allow(clippy::too_many_arguments)] | ||
| pub(crate) fn new_null( |
Check warning
Code scanning / clippy
associated function `new_null` is never used
| use ndarray_layout::ArrayLayout; | ||
| use std::marker::PhantomData; | ||
|
|
||
| pub struct Operator<Hardware, MatMul, Softmax, Rearrange> { |
Check warning
Code scanning / clippy
field `rearrange` is never read
| pub struct Operator<Hardware, MatMul, Softmax, Rearrange> { | ||
| mat_mul: MatMul, | ||
| softmax: Softmax, | ||
| rearrange: Rearrange, |
Check warning
Code scanning / clippy
field `rearrange` is never read
|
|
||
| fn scheme( | ||
| &mut self, | ||
| args: &Self::Args, |
Check warning
Code scanning / clippy
unused variable: `args`
| fn scheme( | ||
| &mut self, | ||
| args: &Self::Args, | ||
| max_workspace_size: usize, |
Check warning
Code scanning / clippy
unused variable: `max_workspace_size`
|
|
||
| fn scheme( | ||
| &mut self, | ||
| args: &Self::Args, |
Check warning
Code scanning / clippy
unused variable: `args`
| fn scheme( | ||
| &mut self, | ||
| args: &Self::Args, | ||
| max_workspace_size: usize, |
Check warning
Code scanning / clippy
unused variable: `max_workspace_size`
| dt, | ||
| nh, | ||
| seq, | ||
| att, |
Check warning
Code scanning / clippy
unused variable: `att`
| seq, | ||
| att, | ||
| dkv, | ||
| dv, |
Check warning
Code scanning / clippy
unused variable: `dv`
| mask, | ||
| pos, | ||
| } = args; | ||
| let &[nh_skv, att_skv, dkv_skv] = kv_layout.strides() else { |
Check warning
Code scanning / clippy
unused variable: `nh_skv`
| let &[nh_skv, att_skv, dkv_skv] = kv_layout.strides() else { | ||
| unreachable!() | ||
| }; | ||
| let &[nh_skr, att_skr, dr_skr] = kr_layout.strides() else { |
Check warning
Code scanning / clippy
unused variable: `dr_skr`
| let &[nh_skr, att_skr, dr_skr] = kr_layout.strides() else { | ||
| unreachable!() | ||
| }; | ||
| let &[nh_sa, dv_sa, dkv_sa] = absorb_layout.strides() else { |
Check warning
Code scanning / clippy
unused variable: `nh_sa`
| let &[nh_skr, att_skr, dr_skr] = kr_layout.strides() else { | ||
| unreachable!() | ||
| }; | ||
| let &[nh_sa, dv_sa, dkv_sa] = absorb_layout.strides() else { |
Check warning
Code scanning / clippy
unused variable: `dv_sa`
| let &[nh_skr, att_skr, dr_skr] = kr_layout.strides() else { | ||
| unreachable!() | ||
| }; | ||
| let &[nh_sa, dv_sa, dkv_sa] = absorb_layout.strides() else { |
Check warning
Code scanning / clippy
unused variable: `dkv_sa`
| let &[nh_skrc, buf_skrc, dh_skrc] = kr_cache_layout.strides() else { | ||
| unreachable!() | ||
| }; | ||
| let ele = dt.nbytes(); |
Check warning
Code scanning / clippy
unused variable: `ele`
| short, | ||
| origin_pos, | ||
| .. | ||
| } => unsafe { |
Check warning
Code scanning / clippy
unnecessary `unsafe` block
2 participants
No description provided.