Feature/andr 50 Логика презентационного слоя + DI#121
Open
xMODDIIx wants to merge 5 commits intoepic/ANDR-81from
Open
Feature/andr 50 Логика презентационного слоя + DI#121xMODDIIx wants to merge 5 commits intoepic/ANDR-81from
xMODDIIx wants to merge 5 commits intoepic/ANDR-81from
Conversation
…а стейта в RegistrationUiState
kish-dev
reviewed
Mar 12, 2026
...mpl/src/main/java/ru/yeahub/authentication/impl/registration/di/RegistrationFeatureModule.kt
Show resolved
Hide resolved
kish-dev
reviewed
Mar 12, 2026
| val isConfirmPasswordVisible: Boolean, | ||
| val isSubmitEnabled: Boolean | ||
| val isSubmitEnabled: Boolean, | ||
| val isLoading: Boolean, |
Collaborator
There was a problem hiding this comment.
У тебя может одновременно быть и:
- Загрузка
- Данные
- Ошибка?
Если нет, тогда надо поделить по sealed interface RegistrationUiState {...}
kish-dev
reviewed
Mar 12, 2026
|
|
||
| private fun submitRegistration() { | ||
| val currentState = _state.value | ||
| _state.update { it.copy(isLoading = true, error = null) } |
Collaborator
There was a problem hiding this comment.
давай вот тут мы как раз и поправим нашу логику.
Не хочется делать _state.update, так как ты из многих мест меняешь свой флоу, а хочется, чтобы он подписывался на изменения с клиента, а потом менялся только через подписку на флоу с данными. Ну и там внутри маппер.
Пример - https://t.me/c/2304084337/7/2905
kish-dev
requested changes
Mar 12, 2026
kish-dev
reviewed
Mar 13, 2026
| val isConfirmPasswordVisible: Boolean, | ||
| val isSubmitEnabled: Boolean | ||
| data class RegistrationFormState( | ||
| val nickname: String = "", |
Collaborator
There was a problem hiding this comment.
Давай уберем значения по умолчанию
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
В RegistrationViewModel инжектится RegistrationUseCase.
Модель состояния RegistrationUiState расширена новыми полями: isLoading (для отображения индикатора загрузки) и error (для передачи текста ошибки на UI).
Добавлена логика обработки экшена SubmitClicked.
Реализован метод submitRegistration(), в котором происходит сбор данных со стейта и вызов UseCase.
Добавлена полноценная обработка ошибок: RegistrationException перехватывается, а доменные ошибки (Network, EmailAlreadyExists, NickNameTaken, InvalidCredentials, Server) маппятся в user-friendly текстовые сообщения для отображения пользователю.
Созданы Koin-модули для всех слоёв фичи регистрации (RegistrationViewModelModule, RegistrationUseCaseModule, RegistrationRepositoryModule, registrationRemoteDataSourceImplModule).
Модули объединены в общий RegistrationFeatureModule для удобного подключения на уровне приложения.