Improve mousemove/mouseup when dragging outside the game canvas#118
Open
jefvel wants to merge 2 commits intoYoYoGames:developfrom
Open
Improve mousemove/mouseup when dragging outside the game canvas#118jefvel wants to merge 2 commits intoYoYoGames:developfrom
jefvel wants to merge 2 commits intoYoYoGames:developfrom
Conversation
Contributor
|
+1 this would be great |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if a player clicks and drags the mouse outside the game window, it'll act as if the mouse was released. It's not consistent with the other non-HTML5 targets.
This PR fixes that. It makes it possible to click, drag, and move the mouse outside the game window. If the user releases the mouse button outside the window it'll trigger as expected.
I've tested this in chrome+firefox and iOS and Android.
An optional feature would be to add the following CSS to the index.html file.
However, it's not really needed. But it helps on mobile targets.